eth_getLogs must return "block unknown" when blockHash is not found

[jpnovais]

Steps to Reproduce

curl -s -H 'content-type:application/json' --data '{"jsonrpc":"2.0","id":"53","method":"eth_getLogs","params":[{"topics":["0x55f4c645c36aa5cd3f443d6be44d7a7a5df9d2100d7139dfc69d4289ee072319"],"blockHash":"0x00000000000000000000000000000000000000000000000000000000000000ff"}]}' http://localhost:8445

Expected behavior:
If the node does not have the block shall return an error instead of saying "That block does not have logs". This can be problematic if the node is behind a load balancer and is not 100% in sync

{"jsonrpc":"2.0","id":"53","error":{"code":-32000,"message":"unknown block"}}

Actual behavior:

{"jsonrpc":"2.0","id":"53","result":[]}

Frequency: Consystently

Versions (Add all that apply)

• Software version: besu 24.10

Notes:

Geth and Infura return unknown block

[jonson]

👋 I think I can grab this one!

[macfarla]

there are plenty of tests already that should guide you too

eg files named like ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getLogs_blockhash.json