Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(besu-test-ledger): enable sending funds to already created account #2250

Closed
AndreAugusto11 opened this issue Jan 8, 2023 · 0 comments · Fixed by #2251
Closed

feat(besu-test-ledger): enable sending funds to already created account #2250

AndreAugusto11 opened this issue Jan 8, 2023 · 0 comments · Fixed by #2251
Labels
enhancement New feature or request

Comments

@AndreAugusto11
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the implementation of createEthTestAccount includes the creation of an account and sends some funds to get things started. It would be important to separate this function in two, in a way that it is possible to send funds to an already created account.

Describe the solution you'd like
Create function sendEthToAccount and call it from createEthTestAccount. If an address already exists we would only need to call the first method.
@AndreAugusto11 AndreAugusto11 added the enhancement New feature or request label Jan 8, 2023
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this issue Jan 8, 2023
@AndreAugusto11
feat(besu-test-ledger): send funds to already created address
93f4efe 
Enable sending funds to an existing account
New method created:
* sendEthToAccount

closes hyperledger-cacti#2250

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
@AndreAugusto11 AndreAugusto11 mentioned this issue Jan 8, 2023
Merged
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this issue Feb 4, 2023
@AndreAugusto11
feat(besu-test-ledger): send funds to already created address
7586c6f 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

closes hyperledger-cacti#2250

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this issue Feb 8, 2023
@AndreAugusto11
feat(besu-test-ledger): send funds to already created address
bafae3f 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

closes hyperledger-cacti#2250

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this issue Mar 31, 2023
@AndreAugusto11 @petermetz
feat(besu-test-ledger): send funds to already created address
737bae7 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

closes hyperledger-cacti#2250

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this issue Apr 2, 2023
@AndreAugusto11 @petermetz
feat(besu-test-ledger): send funds to already created address
7e1ff59 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

closes hyperledger-cacti#2250

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this issue Aug 13, 2023
@AndreAugusto11 @petermetz
feat(besu-test-ledger): send funds to already created address
44de2be 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

Closes hyperledger-cacti#2250

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Aug 13, 2023
@AndreAugusto11 @petermetz
feat(besu-test-ledger): send funds to already created address
3a58508 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

Closes #2250

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@AndreAugusto11 @sandeepnRES
feat(besu-test-ledger): send funds to already created address
fb64660 
Enable sending funds to an existing account

New method created:
* sendEthToAccount

Closes hyperledger-cacti#2250

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(besu-test-ledger): send funds to already created address AndreAugusto11/cacti
1 participant
@AndreAugusto11