Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-go-ethereum): add getBlock and getTransactionReceipt methods to connector #2256

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

rwat17
Copy link
Contributor

@rwat17 rwat17 commented Jan 9, 2023

  • getBlock and getTransactionReceipt added in go-ethereum-socketio-connector
  • Added nullish coalescing in monitor options

Closes: #2255
Signed-off-by: Tomasz Awramski tomasz.awramski@fujitsu.com

@rwat17 rwat17 force-pushed the go-eth-con-improve branch from cfa69c9 to de999db Compare January 10, 2023 10:50
@rwat17 rwat17 changed the title feat(connector-go-ethereum): add getBlock and feat(connector-go-ethereum): add getBlock and getTransactionReceipt methods to connector Jan 10, 2023
@rwat17 rwat17 force-pushed the go-eth-con-improve branch from de999db to ae4be43 Compare January 10, 2023 13:21
outSH added a commit to outSH/cactus that referenced this pull request Jan 10, 2023
- Add a new plugin for storing ledger data into a database (or any other storage in the future).
- Add functional tests for plugin and data access layer operations.
- Increase gas limit on openethereum contract to solve occasional issues in automatic tests.
- Tests assume any postgres database, but for final deployment supabase is assumed.
- Data fed by this plugin can later by visualized by a GUI application or analyzed directly.

Depends on: hyperledger-cacti#2254
Depends on: hyperledger-cacti#2256

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takeutak
Copy link
Contributor

@petermetz @jagpreetsinghsasan Could you review it?

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 Thank you, LGTM!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 Oops, my bad, please fix the merge conflicts (otherwise it LGTM)

@rwat17 rwat17 force-pushed the go-eth-con-improve branch from ae4be43 to 25fe556 Compare March 2, 2023 13:10
@rwat17 rwat17 requested a review from VRamakrishna as a code owner March 2, 2023 13:10
@rwat17
Copy link
Contributor Author

rwat17 commented Mar 2, 2023

@petermetz I am sorry you had to wait that long. Done ✔

@rwat17 rwat17 requested review from izuru0 and petermetz and removed request for VRamakrishna, sandeepnRES, takeutak and izuru0 March 21, 2023 10:19
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 I'm also sorry for the laggy review! LGTM, thanks for fixing the conflicts!

@petermetz petermetz force-pushed the go-eth-con-improve branch from 25fe556 to 39d657a Compare March 28, 2023 01:14
@rwat17 rwat17 force-pushed the go-eth-con-improve branch from 39d657a to db9a0f4 Compare March 28, 2023 09:16
@rwat17
Copy link
Contributor Author

rwat17 commented Mar 28, 2023

@petermetz No problem :)
Rebased with main.

outSH added a commit to outSH/cactus that referenced this pull request Mar 28, 2023
- Add a new plugin for storing ledger data into a database (or any other storage in the future).
- Add functional tests for plugin and data access layer operations.
- Increase gas limit on openethereum contract to solve occasional issues in automatic tests.
- Tests assume any postgres database, but for final deployment supabase is assumed.
- Data fed by this plugin can later by visualized by a GUI application or analyzed directly.
- Add new plugin tests to CI

Depends on: hyperledger-cacti#2254
Depends on: hyperledger-cacti#2256

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
getTransactionReceipt methods to connector

- getBlock and getTransactionReceipt added in
go-ethereum-socketio-connector
- Added nullish coalescing in monitor options

Closes: hyperledger-cacti#2255
Signed-off-by: tomasz awramski <tomasz.awramski@fujitsu.com>
@petermetz petermetz force-pushed the go-eth-con-improve branch from db9a0f4 to 3fa9093 Compare March 28, 2023 22:19
@petermetz petermetz merged commit 3fa9093 into hyperledger-cacti:main Mar 29, 2023
outSH added a commit to outSH/cactus that referenced this pull request Mar 30, 2023
- Add a new plugin for storing ledger data into a database (or any other storage in the future).
- Add functional tests for plugin and data access layer operations.
- Increase gas limit on openethereum contract to solve occasional issues in automatic tests.
- Tests assume any postgres database, but for final deployment supabase is assumed.
- Data fed by this plugin can later by visualized by a GUI application or analyzed directly.
- Add new plugin tests to CI

Depends on: hyperledger-cacti#2254
Depends on: hyperledger-cacti#2256

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this pull request Mar 30, 2023
- Add a new plugin for storing ledger data into a database (or any other storage in the future).
- Add functional tests for plugin and data access layer operations.
- Increase gas limit on openethereum contract to solve occasional issues in automatic tests.
- Tests assume any postgres database, but for final deployment supabase is assumed.
- Data fed by this plugin can later by visualized by a GUI application or analyzed directly.
- Add new plugin tests to CI

Depends on: hyperledger-cacti#2254
Depends on: hyperledger-cacti#2256

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this pull request Apr 2, 2023
- Add a new plugin for storing ledger data into a database (or any other storage in the future).
- Add functional tests for plugin and data access layer operations.
- Increase gas limit on openethereum contract to solve occasional issues in automatic tests.
- Tests assume any postgres database, but for final deployment supabase is assumed.
- Data fed by this plugin can later by visualized by a GUI application or analyzed directly.
- Add new plugin tests to CI

Depends on: hyperledger-cacti#2254
Depends on: hyperledger-cacti#2256

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector-go-ethereum: getBlock and getTransactionReceipt methods
5 participants