-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector-go-ethereum): add getBlock and getTransactionReceipt methods to connector #2256
Conversation
cfa69c9
to
de999db
Compare
de999db
to
ae4be43
Compare
- Add a new plugin for storing ledger data into a database (or any other storage in the future). - Add functional tests for plugin and data access layer operations. - Increase gas limit on openethereum contract to solve occasional issues in automatic tests. - Tests assume any postgres database, but for final deployment supabase is assumed. - Data fed by this plugin can later by visualized by a GUI application or analyzed directly. Depends on: hyperledger-cacti#2254 Depends on: hyperledger-cacti#2256 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@petermetz @jagpreetsinghsasan Could you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwat17 Thank you, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwat17 Oops, my bad, please fix the merge conflicts (otherwise it LGTM)
ae4be43
to
25fe556
Compare
@petermetz I am sorry you had to wait that long. Done ✔ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwat17 I'm also sorry for the laggy review! LGTM, thanks for fixing the conflicts!
25fe556
to
39d657a
Compare
39d657a
to
db9a0f4
Compare
@petermetz No problem :) |
- Add a new plugin for storing ledger data into a database (or any other storage in the future). - Add functional tests for plugin and data access layer operations. - Increase gas limit on openethereum contract to solve occasional issues in automatic tests. - Tests assume any postgres database, but for final deployment supabase is assumed. - Data fed by this plugin can later by visualized by a GUI application or analyzed directly. - Add new plugin tests to CI Depends on: hyperledger-cacti#2254 Depends on: hyperledger-cacti#2256 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
getTransactionReceipt methods to connector - getBlock and getTransactionReceipt added in go-ethereum-socketio-connector - Added nullish coalescing in monitor options Closes: hyperledger-cacti#2255 Signed-off-by: tomasz awramski <tomasz.awramski@fujitsu.com>
db9a0f4
to
3fa9093
Compare
- Add a new plugin for storing ledger data into a database (or any other storage in the future). - Add functional tests for plugin and data access layer operations. - Increase gas limit on openethereum contract to solve occasional issues in automatic tests. - Tests assume any postgres database, but for final deployment supabase is assumed. - Data fed by this plugin can later by visualized by a GUI application or analyzed directly. - Add new plugin tests to CI Depends on: hyperledger-cacti#2254 Depends on: hyperledger-cacti#2256 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Add a new plugin for storing ledger data into a database (or any other storage in the future). - Add functional tests for plugin and data access layer operations. - Increase gas limit on openethereum contract to solve occasional issues in automatic tests. - Tests assume any postgres database, but for final deployment supabase is assumed. - Data fed by this plugin can later by visualized by a GUI application or analyzed directly. - Add new plugin tests to CI Depends on: hyperledger-cacti#2254 Depends on: hyperledger-cacti#2256 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Add a new plugin for storing ledger data into a database (or any other storage in the future). - Add functional tests for plugin and data access layer operations. - Increase gas limit on openethereum contract to solve occasional issues in automatic tests. - Tests assume any postgres database, but for final deployment supabase is assumed. - Data fed by this plugin can later by visualized by a GUI application or analyzed directly. - Add new plugin tests to CI Depends on: hyperledger-cacti#2254 Depends on: hyperledger-cacti#2256 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Closes: #2255
Signed-off-by: Tomasz Awramski tomasz.awramski@fujitsu.com