feat(ledger-browser): refactor routing, improve UI #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
force-pushed
the
ledger_browser_router_fix_pr
branch
2 times, most recently
from
1aaff7c to
0a90676
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Apr 15, 2024
- Use react query to fetch data instead of manual fetches. - Remove dead / duplicated code where applicable. - Minor refactors and fixes. Depends on hyperledger-cacti#3203 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
5 tasks
- Add dynamic routing based on configuration instead of hardcoded one.
- Add MUI and configure custom theme.
Use this new UI kit to create app better bar and ledger selector.
- Cleanup common application code.
- Add sample SQL data to quickly test the GUI
without running persistence plugins.
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
ledger_browser_router_fix_pr
branch
from
0a90676 to
3df3210
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jun 24, 2024
- Use react query to fetch data instead of manual fetches. - Remove dead / duplicated code where applicable. - Minor refactors and fixes. Depends on hyperledger-cacti#3203 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
that referenced
this pull request
Jun 24, 2024
- Use react query to fetch data instead of manual fetches. - Remove dead / duplicated code where applicable. - Minor refactors and fixes. Depends on #3203 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Jul 30, 2024
- Use react query to fetch data instead of manual fetches. - Remove dead / duplicated code where applicable. - Minor refactors and fixes. Depends on hyperledger-cacti#3203 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.