Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ethereum): fix broken validations in tests #3475

Open
ashnashahgrover opened this issue Aug 12, 2024 · 1 comment
Open

test(ethereum): fix broken validations in tests #3475

ashnashahgrover opened this issue Aug 12, 2024 · 1 comment
Labels
enhancement New feature or request good-first-issue-100-introductory P3 Priority 3: Medium

Comments

@ashnashahgrover
Copy link
Contributor

Refactor all the negative test case exception assertions for cactus-plugin-ledger-connector-ethereum so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.

The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: https://github.com/hyperledger/cacti/issues/3455

Acceptance Criteria
Test passes the same as before
Negative test case assertions have been migrated the way it is explained in the parent issue.
@ashnashahgrover ashnashahgrover added the enhancement New feature or request label Aug 12, 2024
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 12, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
2cac59f 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover ashnashahgrover mentioned this issue Aug 12, 2024
Closed
5 tasks
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 16, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
1280003 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover
Copy link
Contributor Author

This issue is now dependent on this issue:

https://github.com/hyperledger/cacti/issues/3487

ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 18, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
f01487a 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 26, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
032e7ae 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 26, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
2f00f8f 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover ashnashahgrover mentioned this issue Aug 26, 2024
Open
@ashnashahgrover ashnashahgrover changed the title test(ethereum): refactor jest test negative test cases test(ethereum): fix broken validations in tests Aug 27, 2024
@ashnashahgrover ashnashahgrover mentioned this issue Sep 3, 2024
Open
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 21, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
438a800 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 21, 2024
@ashnashahgrover
test(ethereum): refactor jest test negative test cases
c034070 
Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue-100-introductory P3 Priority 3: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ethereum): refactor jest test negative test cases ashnashahgrover/cacti
2 participants
@ashnashahgrover @jagpreetsinghsasan