test: refactor jest test negative test cases - phase 1 #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnashahgrover
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that? |
petermetz
reviewed
Aug 19, 2024
There was a problem hiding this comment.
@jagpreetsinghsasan
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?
@ashnashahgrover Yes please! It's looking good in general but we need to make sure the test assertions are working as intended (and if we found an underlying bug then first we have to fix those in order to be able to prove that the asesrtions themselves work as intended)
outSH
requested changes
Aug 22, 2024
packages/cactus-verifier-client/src/test/typescript/unit/verifier-factory.test.ts
Outdated
Show resolved
Hide resolved
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3483
branch
from
947d28a
to
44ebecf
Compare
Primary Changes --------------- 1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API. Fixes hyperledger#3483 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3483
branch
from
44ebecf
to
31c3426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
test: refactor jest test negative test cases - phase 1
Fixes #3483