Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): remove hard dependency on keychain #963

Closed
petermetz opened this issue May 12, 2021 · 4 comments · Fixed by #3338
Closed

feat(connector): remove hard dependency on keychain #963

petermetz opened this issue May 12, 2021 · 4 comments · Fixed by #3338
Assignees
@jagpreetsinghsasan
Labels
Besu Corda enhancement New feature or request Epic Fabric P2 Priority 2: High Quorum Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Milestone
v2.0.0-rc.3

Comments

@petermetz
Copy link
Contributor

Description

As a user of Cactus I want to be able to omit using the keychain if I want to so that I can pick and chose what complexity I take on when I decide to use the framework for my project.

https://chat.hyperledger.org/channel/cactus?msg=WgTabjQho3oFGskSa

Acceptance Criteria

  1. Test coverage for both with and without keychain scenarios
  2. CI suite passing
  3. Avoid depending on shared mutable state, the API server must be horizontally scalable. No file system usage either.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @jagpreetsinghsasan @TonyRowntree @travis-payne
@petermetz petermetz added enhancement New feature or request Fabric Quorum Corda Besu Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus labels May 12, 2021
@petermetz petermetz added this to the v0.6.0 milestone May 12, 2021
@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
@TonyRowntree TonyRowntree self-assigned this Jul 22, 2021
@petermetz petermetz added the Epic label Jul 22, 2021
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@elenaizaguirre
Copy link
Contributor

@TonyRowntree You need to pass this issue to someone, right?

@TonyRowntree
Copy link
Contributor

@elenaizaguirre I will be continuing with the fabric one and (hopefully) get it finished by end of week. The xdai one is up for grabs so feel free to take it if you like :)

@elenaizaguirre
Copy link
Contributor

@TonyRowntree Thank you, I´ll take it

@elenaizaguirre elenaizaguirre mentioned this issue Nov 19, 2021
Open
@petermetz
Copy link
Contributor Author

@elenaizaguirre @TonyRowntree Thank you for coordinating on this!

@petermetz petermetz added the P2 Priority 2: High label Apr 3, 2023
@petermetz petermetz assigned petermetz and unassigned TonyRowntree Apr 3, 2023
@petermetz petermetz modified the milestones: v0.10.0, v2.0.0-rc.1 Aug 20, 2023
@petermetz petermetz removed their assignment Oct 2, 2023
@jagpreetsinghsasan jagpreetsinghsasan self-assigned this Oct 20, 2023
@jagpreetsinghsasan jagpreetsinghsasan moved this from Todo to In Progress in Cacti_Scrum_Project_v2_Release Oct 20, 2023
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 15, 2023
@jagpreetsinghsasan
feat(connector): remove keychain dependency
fdebf49 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Dec 15, 2023
Merged
5 tasks
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 18, 2023
@jagpreetsinghsasan
feat(connector): remove keychain dependency
9f0f120 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 18, 2023
@jagpreetsinghsasan
feat(connector): remove keychain dependency
1f60f47 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Dec 18, 2023
Closed
5 tasks
@jagpreetsinghsasan jagpreetsinghsasan moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Dec 18, 2023
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 3, 2024
@jagpreetsinghsasan
feat(connector): remove keychain dependency
14394b8 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 3, 2024
@jagpreetsinghsasan
feat(connector): remove keychain dependency
49d62e3 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 3, 2024
@jagpreetsinghsasan
feat(connector): remove keychain dependency
1319363 
    Primary Changes
    ---------------
    1. Updated besu, ethereum, quorum and xdai connectors
    to remove hard dependencies on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 20, 2024
@jagpreetsinghsasan
feat(connector): remove hard dependency on keychain
1d43297 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    2. Updated openapi.json file of the above mentioned connectors
       to include the new no-keychain endpoints
    3. Generated code and updated related web-services for the same

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Jun 20, 2024
Merged
5 tasks
@petermetz petermetz modified the milestones: v2.0.0-rc.1, v2.0.0-rc.2 Jun 27, 2024
@petermetz petermetz modified the milestones: v2.0.0-rc.2, v2.0.0-rc.3 Jul 5, 2024
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 11, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
bc34a4b 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 11, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
23d2110 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 12, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
4439c09 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 13, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
8a76c2b 
     Primary Changes
     ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

     Changes required to incorporate 1)
     ----------------------------------
     2. Updated openapi.tpl.json to have non-keychain
        endpoints
     3. Generated code and updated web-services for them
     4. Updated transact( ) and deployContract( ) fx
     5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 15, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
6558ff0 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963
Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 16, 2024
@jagpreetsinghsasan
feat(besu): remove hard dependency on keychain
019fd84 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 18, 2024
@jagpreetsinghsasan @petermetz
feat(besu): remove hard dependency on keychain
47ebdec 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes hyperledger-cacti#963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Jul 18, 2024
@jagpreetsinghsasan @petermetz
feat(besu): remove hard dependency on keychain
f5b60b4 
    Primary Changes
    ---------------
    1. Updated besu connector to remove hard
       dependency on keychain

    Changes required to incorporate 1)
    ----------------------------------
    2. Updated openapi.tpl.json to have non-keychain
       endpoints
    3. Generated code and updated web-services for them
    4. Updated transact( ) and deployContract( ) fx
    5. Added deployContractNoKeychain( ) fx

Fixes #963

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Besu Corda enhancement New feature or request Epic Fabric P2 Priority 2: High Quorum Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Projects
None yet
Milestone
v2.0.0-rc.3
4 participants
@petermetz @elenaizaguirre @TonyRowntree @jagpreetsinghsasan