-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-plugin-ledger-connector-cdl): add new connector plugin #2962
feat(cactus-plugin-ledger-connector-cdl): add new connector plugin #2962
Conversation
packages/cactus-plugin-ledger-connector-cdl/src/main/typescript/cdl-gateway.ts
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-cdl/src/main/typescript/cdl-gateway.ts
Show resolved
Hide resolved
- Remove old connector cactus-plugin-ledger-connector-cdl-socketio. It's been replaced with socketio-based cactus-plugin-ledger-connector-cdl. Depends on hyperledger-cacti#2962 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove old connector cactus-plugin-ledger-connector-cdl-socketio. It's been replaced with socketio-based cactus-plugin-ledger-connector-cdl. Depends on hyperledger-cacti#2962 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH The bundle validation CI job is failing with this:
/home/runner/work/cacti/cacti/packages/cactus-plugin-ledger-connector-cdl/package.json:
dist/cactus-plugin-ledger-connector-cdl.node.umd.min.js
undefined
/home/runner/work/cacti/cacti/packages/cactus-plugin-ledger-connector-cdl/package.json:
dist/cactus-plugin-ledger-connector-cdl.web.umd.min.js
undefined
9d51b54
to
af2ab00
Compare
@petermetz I didn't include these package names because they were not created in the build process. Same seem to apply to all other connector plugins, min bundle creation fails with bunch of errors :/ For now I've added missing package names to please the CI. Please check if bundling is failing on your machine as well or not, and if so, we can create an issue to fix that (and maybe add a script to check if packages were in fact created). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH The bundle validation CI job is failing with this:
/home/runner/work/cacti/cacti/packages/cactus-plugin-ledger-connector-cdl/package.json: dist/cactus-plugin-ledger-connector-cdl.node.umd.min.js undefined /home/runner/work/cacti/cacti/packages/cactus-plugin-ledger-connector-cdl/package.json: dist/cactus-plugin-ledger-connector-cdl.web.umd.min.js undefined@petermetz I didn't include these package names because they were not created in the build process. Same seem to apply to all other connector plugins, min bundle creation fails with bunch of errors :/ For now I've added missing package names to please the CI. Please check if bundling is failing on your machine as well or not, and if so, we can create an issue to fix that (and maybe add a script to check if packages were in fact created).
I rebased onto upstream/main, then yarn install, yarn configure, finally I modified the scripts in the package.json to use prod
as the webpack env parameter (see screenshot) and then ran yarn build:dev
and it worked.
So based on all this I think it is working on my machine. It could be because of some change in the meantime on the main branch.
With all that said, the way you fixed the custom checks is also 100% OK with me, e.g. you declare the min file names but you don't have the scripts defined for the build so the minified webpack build will be skipped anyway. Other packages use the same workaround until we hash out the problems with the minification (which could take a long time so I didn't want us to be slowed down by this kind of issue)
TLDR: The way it is now looks good to me, thank you for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Add new plugin for connecting with CDL service. - It supports as `cactus-plugin-ledger-connector-cdl-socketio` which is now depracated and will be removed shortly. - There are still no automatic tests for this package, only manual script that user can run against CDL instance to see if everything is working. - Fix minor formatting issue in cbdc example (issue from lint) Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
af2ab00
to
bf45630
Compare
- Remove old connector cactus-plugin-ledger-connector-cdl-socketio. It's been replaced with socketio-based cactus-plugin-ledger-connector-cdl. Depends on hyperledger-cacti#2962 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove old connector cactus-plugin-ledger-connector-cdl-socketio. It's been replaced with socketio-based cactus-plugin-ledger-connector-cdl. Depends on #2962 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
cactus-plugin-ledger-connector-cdl-socketio
which is now depracated and will be removed shortly.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.