fix: fixes 1445 and implementing correct interface types

For all the connector class definitions the implementation are fixed to
follow their interface definition and to match in consistent way for all
the connectors

Closes: #1445
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

packages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts

@@ -747,7 +747,7 @@ export class PluginLedgerConnectorBesu
 
   public async deployContract(
     req: DeployContractSolidityBytecodeV1Request,
-  ): Promise<RunTransactionResponse> {
+  ): Promise<DeployContractSolidityBytecodeV1Response> {
     const fnTag = `${this.className}#deployContract()`;
     Checks.truthy(req, `${fnTag} req`);
     if (isWeb3SigningCredentialNone(req.web3SigningCredential)) {
@@ -827,7 +827,13 @@ export class PluginLedgerConnectorBesu
           `${fnTag} Cannot create an instance of the contract because the contractName and the contractName on the keychain does not match`,
         );
       }
-      return runTxResponse;
+
+      // creating solidity byte code response
+      const deployResponse: DeployContractSolidityBytecodeV1Response = {
+        transactionReceipt: runTxResponse.transactionReceipt,
+      };
+
+      return deployResponse;
     }
     throw new Error(
       `${fnTag} Cannot deploy contract without keychainId and the contractName`,

packages/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts

@@ -517,7 +517,7 @@ export class PluginLedgerConnectorXdai
 
   public async deployContract(
     req: DeployContractV1Request,
-  ): Promise<RunTransactionV1Response> {
+  ): Promise<DeployContractV1Response> {
     const fnTag = `${this.className}#deployContract()`;
     Checks.truthy(req, `${fnTag} req`);
     if (isWeb3SigningCredentialNone(req.web3SigningCredential)) {
@@ -592,7 +592,13 @@ export class PluginLedgerConnectorXdai
           await keychainPlugin.set(contractName, JSON.stringify(contractPojo));
         }
       }
-      return runTxResponse;
+
+      // creating contract response
+      const deployResponse: DeployContractV1Response = {
+        transactionReceipt: runTxResponse.transactionReceipt,
+      };
+
+      return deployResponse;
     }
     throw new Error(
       `${fnTag} Cannot deploy contract without keychainId and the contractName`,