Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd-api-server): add ability to install specific versions of plugins #1210

Closed
petermetz opened this issue Aug 12, 2021 · 3 comments · Fixed by #1456
Closed

feat(cmd-api-server): add ability to install specific versions of plugins #1210

petermetz opened this issue Aug 12, 2021 · 3 comments · Fixed by #1456
Assignees
@elenaizaguirre
Labels
API_Server dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Security Related to existing or potential security vulnerabilities
Milestone
v0.10.0

Comments

@petermetz
Copy link
Contributor

Description

As an ops person running Cactus I want to be able to tell the API server exactly what version of a given plugin package to install so that I can do things like downgrading from the latest when it's necessary (security bugs in new versions for example one scenario where this would have to be done urgently in a production environment)

Acceptance Criteria

  1. Test coverage specifically addresses the new feature
  2. Also look into adding support for Github URLs
  3. Also look into adding support for local file system paths
  1. and 3) might already be possible but it hasn't been tested so it needs coverage either way even if it's already working as intended.
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers API_Server dependencies Pull requests that update a dependency file Security Related to existing or potential security vulnerabilities Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert labels Aug 12, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 12, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@petermetz
Copy link
Contributor Author

@elenaizaguirre Just checking: Is this at least partially a match to that other issue that you were working on (you already have a pending PR for it too IIRC).

@elenaizaguirre
Copy link
Contributor

elenaizaguirre commented Oct 25, 2021 •
edited
Loading

@elenaizaguirre Just checking: Is this at least partially a match to that other issue that you were working on (you already have a pending PR for it too IIRC).

@petermetz That PR is closed. It enables the selection of the plugin version to be installed but does not provide the possibility to upgrade or change versions.

@elenaizaguirre elenaizaguirre mentioned this issue Oct 25, 2021
Merged
@petermetz
Copy link
Contributor Author

@elenaizaguirre Got it, thanks for the clarification!

elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 5, 2021
@elenaizaguirre
refactor(api-server): instantiate plugins in api-server without insta…
76272a3 
…ll them

Added parameter action to PluginImport to determine if the plugin
should be installed.

Enabled feature to instantiate plugins from cactus-cmd-api-server
without install it.

Enabled feature to install packages from github

Added method create in class ConfigService to override old configuration.
Method newExampleConfigConvict accepts a boolean parameter to force
configuration override.

Closes hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 5, 2021
@elenaizaguirre
refactor(api-server): instantiate plugins in api-server without insta…
12afee9 
…ll them

Added parameter action to PluginImport to determine if the plugin
should be installed.

Enabled feature to instantiate plugins from cactus-cmd-api-server
without install it.

Enabled feature to install packages from github

Added method create in class ConfigService to override old configuration.
Method newExampleConfigConvict accepts a boolean parameter to force
configuration override.

Closes hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 12, 2021
@elenaizaguirre
fix: added a dummy package
6c142fc 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
@elenaizaguirre elenaizaguirre mentioned this issue Nov 12, 2021
Merged
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 15, 2021
@elenaizaguirre
fix: added a dummy package
9a3cfc8 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 16, 2021
@elenaizaguirre
fix: added a dummy package
ae62d7a 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 17, 2021
@elenaizaguirre
fix: added a dummy package
357e61c 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 17, 2021
@elenaizaguirre
fix: added a dummy package
fe460c5 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 18, 2021
@elenaizaguirre
fix: added a dummy package
c6e8d99 
added a dummy package for tests about install packages from github
sources required for hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
petermetz pushed a commit that referenced this issue Nov 23, 2021
@elenaizaguirre @petermetz
fix: added a dummy package
e1e8aee 
added a dummy package for tests about install packages from github
sources required for #1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Nov 23, 2021
@elenaizaguirre
refactor(api-server): instantiate plugins in api-server without insta…
d223d8b 
…ll them

Added parameter action to PluginImport to determine if the plugin
should be installed.

Enabled feature to instantiate plugins from cactus-cmd-api-server
without install it.

Enabled feature to install packages from github

Added method create in class ConfigService to override old configuration.
Method newExampleConfigConvict accepts a boolean parameter to force
configuration override.

Closes hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
petermetz pushed a commit that referenced this issue Nov 23, 2021
@elenaizaguirre @petermetz
refactor(api-server): instantiate plugins in api-server without insta…
587052c 
…ll them

Added parameter action to PluginImport to determine if the plugin
should be installed.

Enabled feature to instantiate plugins from cactus-cmd-api-server
without install it.

Enabled feature to install packages from github

Added method create in class ConfigService to override old configuration.
Method newExampleConfigConvict accepts a boolean parameter to force
configuration override.

Closes #1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 24, 2021
@elenaizaguirre @Leeyoungone
refactor(api-server): instantiate plugins in api-server without insta…
f463f5e 
…ll them

Added parameter action to PluginImport to determine if the plugin
should be installed.

Enabled feature to instantiate plugins from cactus-cmd-api-server
without install it.

Enabled feature to install packages from github

Added method create in class ConfigService to override old configuration.
Method newExampleConfigConvict accepts a boolean parameter to force
configuration override.

Closes hyperledger-cacti#1210

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenaizaguirre elenaizaguirre

Labels
API_Server dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

refactor(api-server): instantiate plugins in api-server without install them elenaizaguirre/cactus
2 participants
@petermetz @elenaizaguirre