Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ledger-connector-quorum): add socket.io connection to cmd-api-server (and cmd-socket-server) #1604

Closed
takeutak opened this issue Nov 30, 2021 · 0 comments · Fixed by #1933
Labels
enhancement New feature or request

Comments

@takeutak
Copy link
Contributor

takeutak commented Nov 30, 2021

Is your feature request related to a problem? Please describe.
On the current codes, some ledger-connectors (besu, quorum, corda, ...) does not have socket.io connection to cmd-api-server. This communication channel is needed for developing the APIs of sendSyncRequest, sendAsyncRequest, and startMonitor as these are developed in ledger-connector-go-ethereum, ledger-connector-sawtooth, ledger-connector-fabric-socket via socket.io connection to cmd-socket-server.
This feature was already developed in ledger-connectors socket.io version, but in case of merging those codes as #1502, we need to develop it.

Describe the solution you'd like
Add the socket.io connection to the above ledger-connector.

EPIC
#1605

@takeutak takeutak added the enhancement New feature or request label Nov 30, 2021
outSH added a commit to outSH/cactus that referenced this issue Mar 17, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 21, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Apr 7, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Apr 11, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue Apr 13, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit that referenced this issue Apr 13, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: #1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
micoferdinand98 pushed a commit to micoferdinand98/cactus that referenced this issue May 5, 2022
…nnector

Add three new endpoints to quorum ledger connector achieve legacy
verifier compatibility. InvokeRawWeb3EthContractEndpoint can be used to
form any call to deployed contract. InvokeRawWeb3EthMethodEndpoint can
be used to call any web3.eth function. Both are marked as low-level
functions, should be used only when there's no designated endpoint for
given functionality yet. WatchBlocksV1Endpoint can be used to monitor
new block headers / data from the ledger. Type of the output is
determined from input option flag. Extend QuorumApiClient to support
Verifier interface, that is: block monitoring, and sending sync/async
requests. Sending requests is marked as deprecated, because user can use
direct REST calls from generated ApiClient, nevertheless this API was
requested by one of the teams. Added functional tests for two new,
request based endpoints. Moved verifier-besu integration test to
besu-test package. Added verifier-quorum integration test, it
supplements direct endpoint tests and provides a reference for API
usage. Added support for QuorumApiClient in Verifier.

Closes: hyperledger-cacti#1604
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant