-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-server): shutdown hook configuration is using wrong config key #1619
Labels
Comments
@petermetz: Can you please assign this issue onto my name as discussed yesterday |
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 3, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
@m-courtin You got it, thank you for reporting! |
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 8, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 10, 2021
Unit tests for testing default config behaviour + user-defined configuration for shutdown hook Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 10, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 10, 2021
Unit tests for testing default config behaviour + user-defined configuration for shutdown hook Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 10, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
⏳ Alright! Looks like we need to wait for some dependencies: 💡 Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 15, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 15, 2021
Need to set apiServerOptions.configFile to empty string as otherwise the build pipeline is failing Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 15, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
added a commit
to m-courtin/cactus
that referenced
this issue
Dec 15, 2021
Need to set apiServerOptions.configFile to empty string as otherwise the build pipeline is failing Closes: hyperledger-cacti#1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
petermetz
pushed a commit
that referenced
this issue
Dec 15, 2021
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken. Closes: #1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
petermetz
pushed a commit
that referenced
this issue
Dec 15, 2021
Need to set apiServerOptions.configFile to empty string as otherwise the build pipeline is failing Closes: #1619 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken.
Depends on #1649
The text was updated successfully, but these errors were encountered: