Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-api-server): add express static rate limiting #1840

Closed
1 task
petermetz opened this issue Feb 7, 2022 · 0 comments · Fixed by #1908
Closed
1 task

fix(cmd-api-server): add express static rate limiting #1840

petermetz opened this issue Feb 7, 2022 · 0 comments · Fixed by #1908
Assignees
@petermetz
Labels
API_Server bug Something isn't working dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Contributor

petermetz commented Feb 7, 2022 •
edited
Loading

Tracking issue for:

app.get("/*", (_, res) => res.sendFile(resolvedIndexHtml));

Screenshot 2022-02-07 at 15-43-24 Build software better, together
@petermetz petermetz added API_Server bug Something isn't working dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities labels Feb 7, 2022
@petermetz petermetz self-assigned this Feb 7, 2022
petermetz added a commit to petermetz/cacti that referenced this issue Mar 13, 2022
@petermetz
fix(cmd-api-server): add express static rate limiting
272a709 
Introduces rate limiting to the static file serving express
middleware that returns the index.html of the single
page web applications that the API server can host.

The lack of rate limiting was highlighted as a problem by
CodeQL

Fixes hyperledger-cacti#1840

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Mar 14, 2022
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Mar 14, 2022
@petermetz
fix(cmd-api-server): add express static rate limiting
9cf5592 
Introduces rate limiting to the static file serving express
middleware that returns the index.html of the single
page web applications that the API server can host.

The lack of rate limiting was highlighted as a problem by
CodeQL

Fixes hyperledger-cacti#1840

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 14, 2022
@petermetz
fix(cmd-api-server): add express static rate limiting
1edcc40 
Introduces rate limiting to the static file serving express
middleware that returns the index.html of the single
page web applications that the API server can host.

The lack of rate limiting was highlighted as a problem by
CodeQL

Fixes hyperledger-cacti#1840

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Mar 14, 2022
@petermetz
fix(cmd-api-server): add express static rate limiting
190cf12 
Introduces rate limiting to the static file serving express
middleware that returns the index.html of the single
page web applications that the API server can host.

The lack of rate limiting was highlighted as a problem by
CodeQL

Fixes #1840

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
API_Server bug Something isn't working dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cmd-api-server): add express static rate limiting petermetz/cacti
1 participant
@petermetz