Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(performance): parallel test execution #416

Closed
petermetz opened this issue Dec 4, 2020 · 0 comments · Fixed by #648
Closed

fix(performance): parallel test execution #416

petermetz opened this issue Dec 4, 2020 · 0 comments · Fixed by #648
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request
Milestone
v0.4.0

Comments

@petermetz
Copy link
Contributor

Description

As a prospective contributor to Cactus I want to be able to run the tests as fast as possible, in a parallel manner, exploiting the full power of the hardware that I have available to me so that I'm feeling good about working on the project and also am more productive given the lowered turnaround times.

The test runner has a --jobs argument with can be used to enable parallel test execution.
Right now it's turned off because not all of our tests are compatible with this due to some implicit shared state that they depend on.

https://node-tap.org/docs/api/parallel-tests/

Acceptance Criteria

  1. Test execution works in parallel for both integration and unit tests
  2. No flakiness introduced

cc: @takeutak @sfuji822 @jonathan-m-hamilton
@petermetz petermetz added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file Developer_Experience labels Dec 4, 2020
@petermetz petermetz added this to the v0.4.0 milestone Dec 4, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Mar 10, 2021
@petermetz
fix(performance): parallel test execution hyperledger-cacti#416
51b64ad 
Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes hyperledger-cacti#416

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Mar 10, 2021
Merged
petermetz added a commit that referenced this issue Mar 11, 2021
@petermetz
fix(performance): parallel test execution #416
5abcd1e 
Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes #416

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
AzaharaC pushed a commit to kikoncuo/cactus that referenced this issue Mar 12, 2021
@petermetz @AzaharaC
fix(performance): parallel test execution hyperledger-cacti#416
48584bb 
Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes hyperledger-cacti#416

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
@petermetz
fix(performance): parallel test execution hyperledger-cacti#416
40c9920 
Provides a workaround to avoid having to deal
with the issue of the Fabric AIO image not using
randomized host ports by marking the test cases
that use said docker image as 'parallel not ok'
for the tap test runner meaning that all the tests
will run parallel except for these ones for Fabric.

Fixes hyperledger-cacti#416

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix(performance): parallel test execution #416 petermetz/cacti
1 participant
@petermetz