Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dci lint errors #514

Closed
petermetz opened this issue Jan 25, 2021 · 0 comments · Fixed by #516
Closed

fix: dci lint errors #514

petermetz opened this issue Jan 25, 2021 · 0 comments · Fixed by #516
Labels
bug Something isn't working Developer_Experience documentation Improvements or additions to documentation
Milestone
v0.4.0

Comments

@petermetz
Copy link
Contributor

Describe the bug

Currently the DCI linter tool (when executed with the Hyperledger DCI-WG recommendations) at https://dci-lint.herokuapp.com/git-repo-linter is returning a list of issues that we should fix.

To Reproduce

Run the linked tool with the configuration shown on the screenshot to obtain the results

Expected behavior

The amount of errors returned should be zero.

Screenshots

Screenshot_dci_lint_cactus_2021-01-22 16-54-28

Cloud provider or hardware configuration:

N/A

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

v0.3.0

Hyperledger Cactus Plugins/Connectors Used

N/A

Additional context

https://wiki.hyperledger.org/display/DCI/Turning+Recommendations+into+Proposed+Motions+for+the+GB+and+TSC

Recommendation 2: The board should engage contributing companies to fulfill diversity goals
Proposed motion 2: WHEREAS, we on the Governing Board agree to commit an individual from our respective organizations currently involved in Hyperledger or blockchain activities to participation in the DCI Working Group, to: (1) attend recurring meetings, (2) facilitate cross-organizational knowledge sharing and awareness, and (3) foster deeper collaboration in support of DCI initiatives.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton
@petermetz petermetz added bug Something isn't working documentation Improvements or additions to documentation Developer_Experience labels Jan 25, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 25, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jan 26, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
178458a 
Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 26, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
bf63d2e 
Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 26, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
b309e72 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jan 26, 2021
Merged
petermetz added a commit that referenced this issue Feb 1, 2021
@petermetz
fix: dci lint errors #514
99ab3af 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes #514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
ghost pushed a commit to kikoncuo/cactus that referenced this issue Feb 4, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
39fd5ca 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
ghost pushed a commit to kikoncuo/cactus that referenced this issue Feb 4, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
2a8707a 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: Jordi Giron <jordi.giron.amezcua@accenture.com>
ghost pushed a commit to kikoncuo/cactus that referenced this issue Feb 4, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
08004e7 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to kikoncuo/cactus that referenced this issue Feb 8, 2021
@petermetz
fix: dci lint errors hyperledger-cacti#514
f8d30ef 
Also adds a .dcilintignore file to specify which files are
not possible to change without breaking third party dependencies.

TODO: If and when these dependencies get swapped out or they
release new versions with inclusive language, we'll need to
update them accordingly and the ignore file as well.

Fixes hyperledger-cacti#514

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Developer_Experience documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix: dci lint errors #514 petermetz/cacti
1 participant
@petermetz