Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(corda): add prometheus metrics support to the OpenAPI specs of the plugin #535

Closed
jagpreetsinghsasan opened this issue Feb 4, 2021 · 0 comments · Fixed by #865
Closed

feat(corda): add prometheus metrics support to the OpenAPI specs of the plugin #535

jagpreetsinghsasan opened this issue Feb 4, 2021 · 0 comments · Fixed by #865
Assignees
@jagpreetsinghsasan
Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to integrate Prometheus Exporter for the R3 Corda Cactus plugin, Issue #458 details the description in depth and covers up for all the underlying plugins.

cc: @petermetz @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers API_Server Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Feb 5, 2021
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 26, 2021
@jagpreetsinghsasan
feat(corda): prometheus exporter metrics integration
68fb9dc 
	Primary Change
	---
	1. The corda ledger connector plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for getting the prometheus metrics

	Refactorings that were also necessary to incorporate 1) and 2)
	------
	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IPluginLedgerConnectorCordaOptions interface in PluginLedgerConnectorCorda class now has a prometheusExporter object optional field
	5. The PluginLedgerConnectorCorda class has relevant functions to incorporate prometheus exporter
	6. Updated Readme.md about the prometheus exporter
	7. Updated the test case located at packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/deploy-cordapp-jars-to-nodes.test.ts
	8. Updated the OpenAPI spec file to have run-transaction endpoint which currently returns NOT_IMPLEMENTED with 501 code.

Resolve hyperledger-cacti#535

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Apr 26, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 26, 2021
@jagpreetsinghsasan
feat(corda): prometheus exporter metrics integration
593848f 
        Primary Change
        ---
        1. The corda ledger connector plugin now includes the prometheus metrics exporter integration
        2. OpenAPI spec now has api endpoint for getting the prometheus metrics

        Refactorings that were also necessary to incorporate 1) and 2)
        ------
        3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
        4. IPluginLedgerConnectorCordaOptions interface in PluginLedgerConnectorCorda class now has a prometheusExporter object optional field
        5. The PluginLedgerConnectorCorda class has relevant functions to incorporate prometheus exporter
        6. Updated Readme.md about the prometheus exporter
        7. Updated the test case located at packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/deploy-cordapp-jars-to-nodes.test.ts
        8. Updated the OpenAPI spec file to have run-transaction endpoint which currently returns NOT_IMPLEMENTED with 501 code.

Resolve hyperledger-cacti#535

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 26, 2021
@jagpreetsinghsasan
feat(corda): prometheus exporter metrics integration
195819a 
        Primary Change
        ---
        1. The corda ledger connector plugin now includes the prometheus metrics exporter integration
        2. OpenAPI spec now has api endpoint for getting the prometheus metrics

        Refactorings that were also necessary to incorporate 1) and 2)
        ------
        3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
        4. IPluginLedgerConnectorCordaOptions interface in PluginLedgerConnectorCorda class now has a prometheusExporter object optional field
        5. The PluginLedgerConnectorCorda class has relevant functions to incorporate prometheus exporter
        6. Updated Readme.md about the prometheus exporter
        7. Updated the test case located at packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/deploy-cordapp-jars-to-nodes.test.ts
        8. Updated the OpenAPI spec file to have run-transaction endpoint which currently returns NOT_IMPLEMENTED with 501 code.

Resolve hyperledger-cacti#535

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 28, 2021
@jagpreetsinghsasan
feat(corda): prometheus exporter metrics integration
2cd308b 
        Primary Change
        ---
        1. The corda ledger connector plugin now includes the prometheus metrics exporter integration
        2. OpenAPI spec now has api endpoint for getting the prometheus metrics

        Refactorings that were also necessary to incorporate 1) and 2)
        ------
        3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
        4. IPluginLedgerConnectorCordaOptions interface in PluginLedgerConnectorCorda class now has a prometheusExporter object optional field
        5. The PluginLedgerConnectorCorda class has relevant functions to incorporate prometheus exporter
        6. Updated Readme.md about the prometheus exporter
        7. Updated the test case located at packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/deploy-cordapp-jars-to-nodes.test.ts
        8. Updated the OpenAPI spec file to have run-transaction endpoint which currently returns NOT_IMPLEMENTED with 501 code.

Resolve hyperledger-cacti#535

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Apr 28, 2021
@jagpreetsinghsasan @petermetz
feat(corda): prometheus exporter metrics integration
9f37755 
        Primary Change
        ---
        1. The corda ledger connector plugin now includes the prometheus metrics exporter integration
        2. OpenAPI spec now has api endpoint for getting the prometheus metrics

        Refactorings that were also necessary to incorporate 1) and 2)
        ------
        3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
        4. IPluginLedgerConnectorCordaOptions interface in PluginLedgerConnectorCorda class now has a prometheusExporter object optional field
        5. The PluginLedgerConnectorCorda class has relevant functions to incorporate prometheus exporter
        6. Updated Readme.md about the prometheus exporter
        7. Updated the test case located at packages/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/deploy-cordapp-jars-to-nodes.test.ts
        8. Updated the OpenAPI spec file to have run-transaction endpoint which currently returns NOT_IMPLEMENTED with 501 code.

Resolve #535

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(corda): prometheus exporter metrics integration jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan