Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-server): add prometheus metrics support to the OpenAPI specs of the plugin #539

Closed
jagpreetsinghsasan opened this issue Feb 4, 2021 · 0 comments · Fixed by #749
Closed

feat(api-server): add prometheus metrics support to the OpenAPI specs of the plugin #539

jagpreetsinghsasan opened this issue Feb 4, 2021 · 0 comments · Fixed by #749
Assignees
@jagpreetsinghsasan
Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to integrate Prometheus Exporter for the Api Server Cactus plugin, Issue #458 details the description in depth and covers up for all the underlying plugins.

cc: @petermetz @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers API_Server Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Feb 5, 2021
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 30, 2021
@jagpreetsinghsasan
feat(api-server): add prometheus exporter
7295519 
	Primary Change
	--------------

	1. The api-server plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IApiServerConstructorOptions interface in ApiServer class now has a prometheusExporter optional field
	5. The ApiServer class has relevant functions and codes to incorporate prometheus exporter
	6. runtime-plugin-imports.test.ts is changed to incorporate the prometheus exporter
	7. Added Readme.md on the prometheus exporter usage

Resolve hyperledger-cacti#539

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 30, 2021
@jagpreetsinghsasan
feat(api-server): add prometheus exporter
d5c3da0 
	Primary Change
	--------------

	1. The api-server plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IApiServerConstructorOptions interface in ApiServer class now has a prometheusExporter optional field
	5. The ApiServer class has relevant functions and codes to incorporate prometheus exporter
	6. runtime-plugin-imports.test.ts is changed to incorporate the prometheus exporter
	7. Added Readme.md on the prometheus exporter usage

Resolve hyperledger-cacti#539

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 30, 2021
@jagpreetsinghsasan
feat(api-server): add prometheus exporter
d329213 
	Primary Change
	--------------

	1. The api-server plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IApiServerConstructorOptions interface in ApiServer class now has a prometheusExporter optional field
	5. The ApiServer class has relevant functions and codes to incorporate prometheus exporter
	6. runtime-plugin-imports.test.ts is changed to incorporate the prometheus exporter
	7. Added Readme.md on the prometheus exporter usage
	8. Fixed Readme.md under keychain-memory and consortium-manual plugins

Resolve hyperledger-cacti#539

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Mar 30, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 31, 2021
@jagpreetsinghsasan
feat(api-server): add prometheus exporter
142adba 
	Primary Change
	--------------

	1. The api-server plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IApiServerConstructorOptions interface in ApiServer class now has a prometheusExporter optional field
	5. The ApiServer class has relevant functions and codes to incorporate prometheus exporter
	6. runtime-plugin-imports.test.ts is changed to incorporate the prometheus exporter
	7. Added Readme.md on the prometheus exporter usage
	8. Fixed Readme.md under keychain-memory and consortium-manual plugins

Resolve hyperledger-cacti#539

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Mar 31, 2021
@jagpreetsinghsasan @petermetz
feat(api-server): add prometheus exporter
c348aa4 
	Primary Change
	--------------

	1. The api-server plugin now includes the prometheus metrics exporter integration
	2. OpenAPI spec now has api endpoint for the getting the prometheus metrics

	Refactorings that were also necessary to accomodate 1) and 2)
	------------------------------------------------------------

	3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint
	4. IApiServerConstructorOptions interface in ApiServer class now has a prometheusExporter optional field
	5. The ApiServer class has relevant functions and codes to incorporate prometheus exporter
	6. runtime-plugin-imports.test.ts is changed to incorporate the prometheus exporter
	7. Added Readme.md on the prometheus exporter usage
	8. Fixed Readme.md under keychain-memory and consortium-manual plugins

Resolve #539

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
API_Server enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-server): add prometheus exporter jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan