Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): dependent issues bot workflow has no job id #848

Closed
petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #849
Closed

fix(ci): dependent issues bot workflow has no job id #848

petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #849
Assignees
@petermetz
Labels
bug Something isn't working

Comments

@petermetz
Copy link
Contributor

petermetz commented Apr 23, 2021 •
edited
Loading

Hi Peter,

Thanks for contacting GitHub Support.

There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

jobs:
  check:
    runs-on: ubuntu-latest
---

You can rename the job in that workflow to Dependabot Issues to match the required status check name:

jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan @arnab-roy
@petermetz petermetz added the bug Something isn't working label Apr 23, 2021
@petermetz petermetz self-assigned this Apr 23, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
fix(ci): dependent issues bot workflow has no job id hyperledger-cact…
7a68717 
…i#848

There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

jobs:
  check:
    runs-on: ubuntu-latest
---
You can rename the job in that workflow to Dependabot Issues to match the required status check name:

jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
fix(ci): dependent issues bot workflow has no job id hyperledger-cact…
392f67d 
…i#848

There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
---
```

You can rename the job in that workflow to Dependabot Issues to match the required status check name:

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----
```
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

Fixes hyperledger-cacti#848

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Apr 23, 2021
Merged
petermetz added a commit that referenced this issue Apr 27, 2021
@petermetz
fix(ci): dependent issues bot workflow has no job id #848
af61202 
There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
---
```

You can rename the job in that workflow to Dependabot Issues to match the required status check name:

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----
```
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

Fixes #848

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): dependent issues bot workflow has no job id #848 petermetz/cacti
1 participant
@petermetz