Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-aws-secretmanager): create aws secret manager plugin #912

Closed
jagpreetsinghsasan opened this issue May 4, 2021 · 2 comments · Fixed by #964
Closed

feat(keychain-aws-secretmanager): create aws secret manager plugin #912

jagpreetsinghsasan opened this issue May 4, 2021 · 2 comments · Fixed by #964
Assignees
@jagpreetsinghsasan
Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented May 4, 2021 •
edited by petermetz
Loading

Description

As a developer, I want to create a plugin for aws secret manager and perform tasks related to secret management like createSecret and retrieveSecret sort of functionalities.

For reference,
https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html

Acceptance Criteria

  1. New package to be created as @hyperledger/cactus-plugin-keychain-aws-sm
  2. Plugin must implement the central keychain plugin Typescript interface we have in the core-api package
  3. End to end tests to be written that verify that the plugin does indeed work by leveraging localstack
  4. In a separate PR to this add a helper class in the test-tooling package called LocalstackTestContainer which launches a localstack container
  5. Make sure to have the healthcheck of the local stack container passing as part of the start() method's return value (the promise should only resolve once the container is healthy and the localstack services are up and running, ready to serve requests)
  6. The helper class to have methods to expose the credentials, port numbers, etc. that are required to configure/instantiate the PluginKeychainAwsSm class which is to be implemented as part of the package from point 1)

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy
@jagpreetsinghsasan
Copy link
Contributor Author

@petermetz what should be the possible acceptance criteria?

@jagpreetsinghsasan jagpreetsinghsasan changed the title feat(keychain-awssm): create aws secret manager plugin feat(keychain-aws-secretmanager): create aws secret manager plugin May 4, 2021
@jagpreetsinghsasan jagpreetsinghsasan added Developer_Experience Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. good-first-issue Good for newcomers labels May 4, 2021
@jagpreetsinghsasan jagpreetsinghsasan self-assigned this May 4, 2021
@petermetz
Copy link
Contributor

@petermetz what should be the possible acceptance criteria?

@jagpreetsinghsasan Updated the issue description with it.

jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 13, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
6d4ffe3 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-aws-sm under packages/
	2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

	Refactorings that were also necessary to incorporate 1) and 2)
	---
	3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 13, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
1176dcd 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 13, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
868a1d2 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue May 13, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 17, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
b65b7ec 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 18, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
9ecce7d 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 18, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
d751bd6 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 20, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
a48d04c 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 25, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
4d77763 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 7, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
d6b9d1c 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 7, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
1e1e090 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 14, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
129c0a5 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 15, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
543dc6e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 15, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
ff29cce 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 6, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
64de577 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Jul 12, 2021
@jagpreetsinghsasan @Leeyoungone
feat(aws-sm): added keychain plugin for aws secret manager
16e67c7 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 21, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
2aef4bb 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 21, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
350328a 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-aws-sm under packages/
	2. Added Localstack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing
	Refactorings that were also necessary to incorporate 1) and 2)
	---
	3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 21, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
fd67476 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
909968f 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
59852da 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 26, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
144a64e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 26, 2021
@jagpreetsinghsasan
feat(aws-sm): added keychain plugin for aws secret manager
a0a08eb 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Jul 26, 2021
@jagpreetsinghsasan @Leeyoungone
feat(aws-sm): added keychain plugin for aws secret manager
dadf70c 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added LocalStack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing

        Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting the Localstack class, its interface and constants

Resolves hyperledger-cacti#912

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Jul 28, 2021
@jagpreetsinghsasan @petermetz
feat(aws-sm): added keychain plugin for aws secret manager
ed6db9e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves #912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
@Leeyoungone Leeyoungone mentioned this issue Jul 28, 2021
Merged
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@jagpreetsinghsasan @RafaelAPB
feat(aws-sm): added keychain plugin for aws secret manager
0996376 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-aws-sm under packages/
        2. Added Localstack under cactus-test-tooling/src/main/typescript for
		local aws secret manager deployment and testing

		Refactorings that were also necessary to incorporate 1) and 2)
        ---
        3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript
		for exporting LocalStack class, its interfaces and constants

Resolves hyperledger-cacti#912

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-sm): added keychain plugin for aws secret manager jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan