Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-aws-sm): bootstrap README.md #968

Closed
jagpreetsinghsasan opened this issue May 17, 2021 · 2 comments · Fixed by #1940
Closed

feat(keychain-aws-sm): bootstrap README.md #968

jagpreetsinghsasan opened this issue May 17, 2021 · 2 comments · Fixed by #1940
Assignees
@jagpreetsinghsasan
Labels
documentation Improvements or additions to documentation Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. P2 Priority 2: High

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to update the README.md describing the plugin and examples for its usage.

Acceptance Criteria

  1. README.md present at packages/cactus-plugin-keychain-aws-sm/README.md should be updated with the plugin description and example usage.
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue May 17, 2021
Merged
@petermetz petermetz changed the title feat(aws-sm): Update Readme feat(keychain-aws-sm): bootstrap README.md May 17, 2021
@petermetz petermetz added documentation Improvements or additions to documentation Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. labels May 17, 2021
@suvajit-sarkar suvajit-sarkar self-assigned this Aug 3, 2021
@petermetz petermetz added the P2 Priority 2: High label Jan 18, 2022
@jagpreetsinghsasan
Copy link
Contributor Author

@petermetz I have started working on this in the meanwhile.

@jagpreetsinghsasan jagpreetsinghsasan self-assigned this Mar 7, 2022
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Mar 22, 2022
@jagpreetsinghsasan
feat(keychain-aws-sm): bootstrap readme.md
6840a71 
	Primary Changes
	---
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes hyperledger-cacti#968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Mar 22, 2022
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 1, 2022
@jagpreetsinghsasan
feat(keychain-aws-sm): bootstrap readme.md
6a08eed 
	Primary Changes
	---------------
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes hyperledger-cacti#968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 1, 2022
@jagpreetsinghsasan @petermetz
feat(keychain-aws-sm): bootstrap readme.md
d7616e0 
	Primary Changes
	---------------
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes hyperledger-cacti#968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Apr 1, 2022
@jagpreetsinghsasan @petermetz
feat(keychain-aws-sm): bootstrap readme.md
51fd852 
	Primary Changes
	---------------
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes hyperledger-cacti#968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Apr 1, 2022
@jagpreetsinghsasan @petermetz
feat(keychain-aws-sm): bootstrap readme.md
060f351 
	Primary Changes
	---------------
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes #968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@petermetz
Copy link
Contributor

@petermetz I have started working on this in the meanwhile.

@jagpreetsinghsasan Great, thanks for being proactive ;-)

micoferdinand98 pushed a commit to micoferdinand98/cactus that referenced this issue May 5, 2022
@jagpreetsinghsasan @micoferdinand98
feat(keychain-aws-sm): bootstrap readme.md
083e9f4 
	Primary Changes
	---------------
	1. Updated the README.md located at packages/cactus-plugin-keychain-aws-sm/README.md
	2. The aws secret manager plugin now includes the prometheus metrics exporter integration
	3. OpenApi spec now has api endpoint for getting the prometheus metrics

Fixes hyperledger-cacti#968

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
documentation Improvements or additions to documentation Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. P2 Priority 2: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(keychain-aws-sm): bootstrap readme.md jagpreetsinghsasan/cactus
3 participants
@petermetz @suvajit-sarkar @jagpreetsinghsasan