Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter added for go and javascript #259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kartikaysaxena
Copy link

@kartikaysaxena kartikaysaxena commented Apr 10, 2024

Fixes #215

Works like make lint-js and make lint-go

Added a Makefile which has targets mainly lint-js and lint-go and a combined target lint which executes the scripts added to lint the code

@kartikaysaxena kartikaysaxena requested a review from a team April 10, 2024 21:25
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@kartikaysaxena
Copy link
Author

PTAL @davidkel

@davidkel
Copy link
Contributor

@kartikaysaxena I really like the idea you have put forward but I think the actual work is more comprehensive than this PR. I have captured my thoughts in this issue #262
Please add to the issue any thoughts you have and if you are interested I can assign the issue to you.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting rules required
2 participants