Clean Makefile

[zhuyuanmao]

As the Cello project grows, the Makefile commands are outdated. We would like to know which commands aren't working. Please list the commands here.

[alienishi]

1: make start : This command starts the service, but it doesn't specify which service to start. It relies on the start-docker-compose rule, which starts the services defined in the bootup/docker-compose-files/${COMPOSE_FILE} file. However, the value of ${COMPOSE_FILE} is determined by the MODE variable, which is set to prod by default. If you want to use this command, ensure that the appropriate value is set for ${COMPOSE_FILE} and that the necessary configuration files are present.

2: make stop: This command stops the service, but it doesn't specify which service to stop. It relies on the stop-docker-compose rule, which stops the services defined in the bootup/docker-compose-files/${COMPOSE_FILE} file. Similar to the start command, ensure that the value of ${COMPOSE_FILE} is correctly set.

3: make restart: This command restarts the services, but it relies on the stop and start commands. As mentioned above, ensure that the necessary configurations are in place for those commands to work correctly.

4: make clean-images: This command is intended to clean all Cello-related Docker images. However, it executes the clean rule, which stops services and cleans Docker containers. It doesn't specifically target cleaning Docker images. If you want to clean Docker images, you may need to modify the command to remove the images instead of stopping services and cleaning containers.

5: make check-dashboard: This command checks the dashboard but relies on the docker-compose command with a specific configuration file. Ensure that the necessary configuration files are present and correctly set up for the dashboard check to work as expected.

[alienishi]

Hi @zhuyuanmao
Sure i can make a patch to fix these makefile rules
Please do assign this issue to me

[aceppaluni]

Hi, Can I take this on?

[yeasy]

Hi, Can I take this on?

Go ahead :)

[aceppaluni]

Hi @yeasy :)

I noticed there is more then one Makefile. There seems to be both Makefile and Makefile.old. Are you essentially looking to combine them both?

[yeasy]

Hi @yeasy :)

I noticed there is more then one Makefile. There seems to be both Makefile and Makefile.old. Are you essentially looking to combine them both?

You may ignore the Makefile.old.