Skip to content

Commit 70bff28

Browse files
committed
[FAB-5197]Check all prop-responses in balance-transfer
"balance-transfer" app doesn't check all of the proposal responses. An app sends a transaction proposal to multiple peers and get multiple responses. However, the only first response "proposalResponses[0]" is checked repeatedly in the loop. This patch fixes the code to check all of the array value of proposalResponses correctly. Change-Id: Id61e691eb4d1c3a6c4a7a390584dfd74f1fc6196 Signed-off-by: Yuki Kondo <yuki.kondo@hal.hitachi.com>
1 parent f9c2954 commit 70bff28

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

balance-transfer/app/install-chaincode.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ var installChaincode = function(peers, chaincodeName, chaincodePath,
4747
var all_good = true;
4848
for (var i in proposalResponses) {
4949
let one_good = false;
50-
if (proposalResponses && proposalResponses[0].response &&
51-
proposalResponses[0].response.status === 200) {
50+
if (proposalResponses && proposalResponses[i].response &&
51+
proposalResponses[i].response.status === 200) {
5252
one_good = true;
5353
logger.info('install proposal was good');
5454
} else {

balance-transfer/app/instantiate-chaincode.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ var instantiateChaincode = function(channelName, chaincodeName, chaincodeVersion
6363
var all_good = true;
6464
for (var i in proposalResponses) {
6565
let one_good = false;
66-
if (proposalResponses && proposalResponses[0].response &&
67-
proposalResponses[0].response.status === 200) {
66+
if (proposalResponses && proposalResponses[i].response &&
67+
proposalResponses[i].response.status === 200) {
6868
one_good = true;
6969
logger.info('instantiate proposal was good');
7070
} else {

balance-transfer/app/invoke-transaction.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ var invokeChaincode = function(peersUrls, channelName, chaincodeName, fcn, args,
5555
var all_good = true;
5656
for (var i in proposalResponses) {
5757
let one_good = false;
58-
if (proposalResponses && proposalResponses[0].response &&
59-
proposalResponses[0].response.status === 200) {
58+
if (proposalResponses && proposalResponses[i].response &&
59+
proposalResponses[i].response.status === 200) {
6060
one_good = true;
6161
logger.info('transaction proposal was good');
6262
} else {

0 commit comments

Comments
 (0)