[FAB-4893] Update vendoring to dep (lint fix)

This patch fixes the lint target by depending on populate.

Change-Id: Id1362997d0cf7201c0294d5defb47a9803dc060f
Signed-off-by: Troy Ronda <troy@troyronda.com>

Makefile

@@ -14,7 +14,8 @@
 # clean: stops docker conatainers used for integration testing
 # mock-gen: generate mocks needed for testing (using mockgen)
 # populate: populates generated files (not included in git) - currently only vendor
-# populate-vendor: populate the vendor directory based on the lock 
+# populate-vendor: populate the vendor directory based on the lock
+# populate-clean: cleans up populated files (might become part of clean eventually) 
 #
 #
 # Instructions to generate .tx files used for creating channels:
@@ -50,7 +51,7 @@ checks: depend license lint spelling
 license:
 	@test/scripts/check_license.sh
 
-lint:
+lint: populate
 	@test/scripts/check_lint.sh
 
 spelling:
@@ -93,9 +94,11 @@ populate-vendor:
 	@echo "Populating vendor ..."
 	@dep ensure -vendor-only
 
+populate-clean:
+	rm -Rf vendor
+
 clean:
 	rm -Rf /tmp/enroll_user /tmp/msp /tmp/keyvaluestore
 	rm -f integration-report.xml report.xml
 	cd test/fixtures && docker-compose down
 	cd test/fixtures && docker-compose -f docker-compose-unit.yaml down
-	rm -Rf vendor

test/scripts/dependencies.sh

@@ -17,7 +17,7 @@ if [ "$FABRIC_SDKGO_DEPEND_INSTALL" = "true" ]; then
     go get -u github.com/client9/misspell/cmd/misspell
     go get -u github.com/golang/lint/golint
     go get -u golang.org/x/tools/cmd/goimports
-	go get -u github.com/golang/mock/mockgen
+    go get -u github.com/golang/mock/mockgen
 fi
 
 # Install specific version of go dep (particularly for CI)