Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Commit d0a28cf

Browse files
committed
[FAB-6670] Update AttrReq class definition
Changed property 'require' to 'optional' to match the update fabric-ca API definition. Change-Id: I435f8c66a4656ae34d73ca64bf9a14a750eb659f Signed-off-by: Gari Singh <gari.r.singh@gmail.com>
1 parent 67eafc6 commit d0a28cf

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/main/java/org/hyperledger/fabric_ca/sdk/EnrollmentRequest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ private JsonObject toJsonObject() {
164164
for (AttrReq attrReq : attrreqs.values()) {
165165
JsonObjectBuilder i = Json.createObjectBuilder();
166166
i.add("name", attrReq.name);
167-
if (attrReq.require != null) {
168-
i.add("require", attrReq.require);
167+
if (attrReq.optional != null) {
168+
i.add("optional", attrReq.optional);
169169
}
170170
ab.add(i);
171171

@@ -206,7 +206,7 @@ public AttrReq addAttrReq(String name) throws InvalidArgumentException {
206206

207207
public class AttrReq {
208208
final String name;
209-
Boolean require = null;
209+
Boolean optional = null;
210210

211211
AttrReq(String name) {
212212
this.name = name;
@@ -216,8 +216,8 @@ public class AttrReq {
216216
attrreqs.put(name, this);
217217
}
218218

219-
public AttrReq setRequire(boolean require) {
220-
this.require = require;
219+
public AttrReq setOptional(boolean optional) {
220+
this.optional = optional;
221221
return this;
222222
}
223223
}

src/test/java/org/hyperledger/fabric_ca/sdk/EnrollmentRequestTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,14 @@ public void testEnrollReqToJsonAttr() throws Exception {
123123
testEnrollReq.setKeyPair(null);
124124
testEnrollReq.setCAName(caName);
125125
testEnrollReq.addAttrReq("foo");
126-
testEnrollReq.addAttrReq("foorequired").setRequire(true);
127-
testEnrollReq.addAttrReq("foofalse").setRequire(false);
126+
testEnrollReq.addAttrReq("foorequired").setOptional(false);
127+
testEnrollReq.addAttrReq("foofalse").setOptional(true);
128128

129129
String s = testEnrollReq.toJson();
130130
assertNotNull(s);
131131
assertTrue(s.contains("\"attr_reqs\":["));
132-
assertTrue(s.contains("\"name\":\"foorequired\",\"require\":true"));
133-
assertTrue(s.contains("\"name\":\"foofalse\",\"require\":false"));
132+
assertTrue(s.contains("\"name\":\"foorequired\",\"optional\":false"));
133+
assertTrue(s.contains("\"name\":\"foofalse\",\"optional\":true"));
134134

135135
}
136136

src/test/java/org/hyperledger/fabric_ca/sdkintegration/HFCAClientIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public void testRegisterAttributes() throws Exception {
132132
fail("Secret returned from RegistrationRequest not match : " + user.getEnrollmentSecret());
133133
}
134134
EnrollmentRequest req = new EnrollmentRequest();
135-
req.addAttrReq("testattr2").setRequire(true);
135+
req.addAttrReq("testattr2").setOptional(false);
136136

137137
user.setEnrollment(client.enroll(user.getName(), user.getEnrollmentSecret(), req));
138138

0 commit comments

Comments
 (0)