[FAB-1872]: Commit genessis block, joining chain.

Currently genesis block is not get committed into
the ledger while chain is created, therefore
the delivery client asks from the ordering service
to bring blocks starting from the sequence zero.

The zero sequence blocks is actually the configuration
block which simple fails validation, because configuration
block sequence expected to come in increasing order.

This commit takes care to get genesis block committed
right after chain created for the first time.

NOTE: we do not need to "re-commit" this block in case
peer get restarted.

Change-Id: I82d6830f540b1772e4134ce380428b0189af9fe3
Signed-off-by: Artem Barger <bartem@il.ibm.com>

core/peer/peer.go

@@ -212,6 +212,10 @@ func CreateChainFromBlock(cb *common.Block) error {
 		return err
 	}
 
+	if err := ledger.Commit(cb); err != nil {
+		peerLogger.Errorf("Unable to get genesis block committed into the ledger, chainID %v", cid)
+		return err
+	}
 	return createChain(cid, ledger, cb)
 }
 

gossip/state/state.go

@@ -112,13 +112,6 @@ func NewGossipStateProvider(chainID string, g gossip.Gossip, committer committer
 		return nil
 	}
 
-	//if the ledger is empty, we need a block from orderer
-	//so don't expect height+1 but expect 0
-	next := height
-	if height > 0 {
-		next = height + 1
-	}
-
 	s := &GossipStateProviderImpl{
 		chainID: chainID,
 
@@ -133,7 +126,7 @@ func NewGossipStateProvider(chainID string, g gossip.Gossip, committer committer
 
 		stopFlag: 0,
 		// Create a queue for payload received
-		payloads: NewPayloadsBuffer(next),
+		payloads: NewPayloadsBuffer(height + 1),
 
 		committer: committer,
 

gossip/state/state_test.go

@@ -294,7 +294,7 @@ func TestNewGossipStateProvider_SendingManyMessages(t *testing.T) {
 
 	msgCount := 10
 
-	for i := 0; i < msgCount; i++ {
+	for i := 1; i <= msgCount; i++ {
 		rawblock := pcomm.NewBlock(uint64(i), []byte{})
 		if bytes, err := pb.Marshal(rawblock); err == nil {
 			payload := &proto.Payload{uint64(i), "", bytes}