Skip to content

Commit

Permalink
FAB-2557 remove overlapping chaincode UTs
Browse files Browse the repository at this point in the history
https://jira.hyperledger.org/browse/FAB-2557

Skipped some chaincode tests with rationale in comments.
Will help reduce UT time.

Change-Id: I74082c97fc9d474b35fe60edfe66fff4eca26f90
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>
  • Loading branch information
Srinivasan Muralidharan committed Mar 1, 2017
1 parent 3eaccbd commit 4f03b14
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
7 changes: 7 additions & 0 deletions core/chaincode/exectransaction_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -471,13 +471,17 @@ func _(chainID string, _ string) error {

// Test deploy of a transaction
func TestExecuteDeployTransaction(t *testing.T) {
//chaincoe is deployed as part of many tests. No need for a separate one for this
t.Skip()
chainID := util.GetTestChainID()

executeDeployTransaction(t, chainID, "example01", "github.com/hyperledger/fabric/examples/chaincode/go/chaincode_example01")
}

// Test deploy of a transaction with a GOPATH with multiple elements
func TestGopathExecuteDeployTransaction(t *testing.T) {
//this is no longer critical as chaincode is assembled in the client side (SDK)
t.Skip()
chainID := util.GetTestChainID()

// add a trailing slash to GOPATH
Expand Down Expand Up @@ -1041,6 +1045,9 @@ func TestGetEvent(t *testing.T) {
// Test the execution of a chaincode that queries another chaincode
// example02 implements "query" as a function in Invoke. example05 calls example02
func TestChaincodeQueryChaincodeUsingInvoke(t *testing.T) {
//this is essentially same as the ChaincodeInvokeChaincode now that
//we don't distinguish between Invoke and Query (there's no separate "Query")
t.Skip()
chainID := util.GetTestChainID()

var peerLis net.Listener
Expand Down
3 changes: 2 additions & 1 deletion core/chaincode/multichains_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import (
)

func TestExecuteInvokeOnManyChains(t *testing.T) {
chains := []string{"chain1", "chain2", "chain3", "chain4"}
//lets use 2 chains to test multi chains
chains := []string{"chain1", "chain2"}
lis, err := initPeer(chains...)
if err != nil {
t.Fail()
Expand Down

0 comments on commit 4f03b14

Please sign in to comment.