Skip to content

Commit

Permalink
add UT guidance to CONTRIBUTING.rst
Browse files Browse the repository at this point in the history
Change-Id: I86a76ba5060858b564efcc409999b5e91d96b190
Signed-off-by: Christopher Ferris <chrisfer@us.ibm.com>
  • Loading branch information
christo4ferris committed May 17, 2017
1 parent bf4f64e commit 52434ce
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion docs/source/CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ What makes a good change request?
definition. Why? Because many open source developers do Test Driven
Development. They place a watch on the directory that invokes the
tests automagically as the code is changed. This is far more
efficient than having to run a whole build between code changes.
efficient than having to run a whole build between code changes. See
`this definition<http://artofunittesting.com/definition-of-a-unit-test/>`__
of unit testing for a good set of criteria to keep in mind for writing
effective unit tests.

- Minimize the lines of code per CR. Why? Maintainers have day jobs,
too. If you send a 1,000 or 2,000 LOC change, how long do you think
Expand Down

0 comments on commit 52434ce

Please sign in to comment.