[FAB-12083] Appease go vet with cancel in cluster

FAB-12083 #done

This change set adds a call to the context cancel function
when the stream cannot be established.

Change-Id: Ie38d5e59e6f6a4635dcf427ea4c2a4cf4d9ff44c
Signed-off-by: yacovm <yacovm@il.ibm.com>

orderer/common/cluster/comm.go

@@ -404,6 +404,7 @@ func (rc *RemoteContext) SubmitStream() (orderer.Cluster_SubmitClient, error) {
 	ctx, cancel := context.WithCancel(context.TODO())
 	submitStream, err := rc.Client.Submit(ctx)
 	if err != nil {
+		cancel()
 		return nil, errors.WithStack(err)
 	}
 	rc.submitStream = submitStream

scripts/golinter.sh

@@ -46,20 +46,9 @@ fi
 
 echo "Checking with go vet"
 PRINTFUNCS="Print,Printf,Info,Infof,Warning,Warningf,Error,Errorf,Critical,Criticalf,Sprint,Sprintf,Log,Logf,Panic,Panicf,Fatal,Fatalf,Notice,Noticef,Wrap,Wrapf,WithMessage"
-OUTPUT="$(go vet -all -lostcancel=false -printfuncs $PRINTFUNCS ./...)"
+OUTPUT="$(go vet -all -printfuncs $PRINTFUNCS ./...)"
 if [ -n "$OUTPUT" ]; then
     echo "The following files contain go vet errors"
     echo $OUTPUT
     exit 1
-fi
-
-# This block should removed once the lostcancel issues have been corrected and
-# the previous invocation of vet should remove the -lostcancel=false option.
-#   FAB-12082 - gossip
-#   FAB-12083 - orderer
-OUTPUT="$(go vet -lostcancel=true ./... 2>&1 | grep -Ev '^#|(fabric/)?gossip/comm/comm_impl.go|(fabric)?orderer/common/cluster/comm.go' || true)"
-if [ -n "$OUTPUT" ]; then
-    echo "The following files contain go vet errors"
-    echo $OUTPUT
-    exit 1
-fi
+fi