Skip to content

Commit

Permalink
Remove dup Transaction timestamp and version fields
Browse files Browse the repository at this point in the history
The Transaction timestamp and version fields are duplicates
of fields that are already on the transaction's ChainHeader, and
nobody is using them.  The header is the appropriate place for these
fields, not in the Transaction itself.  Note, there is a 1-to-1
relationship between the ChainHeader and the Transaction, no
reason to include the fields twice.

Change-Id: I039d4ca07d51d27d0e9c4b1a00f9b39db2ba08c8
Signed-off-by: denyeart <enyeart@us.ibm.com>
  • Loading branch information
denyeart committed Feb 18, 2017
1 parent eab249d commit 907689c
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 52 deletions.
73 changes: 29 additions & 44 deletions protos/peer/transaction.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions protos/peer/transaction.proto
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,9 @@ message ProcessedTransaction {
// to ensure that they are treated atomically.
message Transaction {

// Version indicates message protocol version.
int32 version = 1;

// Timestamp is the local time that the
// message was created by the sender
google.protobuf.Timestamp timestamp = 2;

// The payload is an array of TransactionAction. An array is necessary to
// accommodate multiple actions per transaction
repeated TransactionAction actions = 3;
repeated TransactionAction actions = 1;
}

// TransactionAction binds a proposal to its action. The type field in the
Expand Down

0 comments on commit 907689c

Please sign in to comment.