Skip to content

Commit

Permalink
Update Cobra and pflag vendor libraries
Browse files Browse the repository at this point in the history
The current version of cobra in our vendor folder has a bug where if
a cobra command has a PersistentPreRunE callback, it expects a
PersistentPostRunE callback, too. If it doesn't exist, then it will
panic.

Adding an empty PersistentPostRunE callback is a workaround, updating
cobra (and pflag as it is a dependency) fixes it.

Change 277 depends on this as it has removed the PersistentPostRunE from
the main command. I think it would be nicer to merge this before merging
that.

Change-Id: I77ebd36a83ccff3076fa9f89a34524dfe42b21eb
Signed-off-by: Julian Carrivick <cjulian@au1.ibm.com>
  • Loading branch information
juliancarrivick-ibm authored and gaborh-da committed Aug 3, 2016
1 parent c1b13e3 commit b39c93a
Show file tree
Hide file tree
Showing 17 changed files with 1,547 additions and 976 deletions.
815 changes: 612 additions & 203 deletions vendor/github.com/spf13/cobra/README.md

Large diffs are not rendered by default.

415 changes: 330 additions & 85 deletions vendor/github.com/spf13/cobra/bash_completions.go

Large diffs are not rendered by default.

61 changes: 59 additions & 2 deletions vendor/github.com/spf13/cobra/bash_completions.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

73 changes: 60 additions & 13 deletions vendor/github.com/spf13/cobra/cobra.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b39c93a

Please sign in to comment.