Skip to content

Commit

Permalink
Gossip discovery: validate dead members bug fix
Browse files Browse the repository at this point in the history
When receiving a membership request, the validation
of dead peers messages was done on the top level message instead

Change-Id: I1596358993404af6b01b813e5cbf053c48ba8d31
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
  • Loading branch information
yacovm committed Mar 3, 2017
1 parent 01cc491 commit c9e9cc1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gossip/discovery/discovery_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func (d *gossipDiscoveryImpl) handleMsgFromComm(m *proto.SignedGossipMessage) {
d.logger.Warning("Membership response contains an invalid message from an offline peer", err)
return
}
if !d.crypt.ValidateAliveMsg(m) {
if !d.crypt.ValidateAliveMsg(dm) {
d.logger.Warningf("Alive message isn't authentic, someone spoofed %s's identity", dm.GetAliveMsg().Membership)
continue
}
Expand Down

0 comments on commit c9e9cc1

Please sign in to comment.