Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EndpointError to ErrorDetail #2971

Closed
andrew-coleman opened this issue Oct 6, 2021 · 0 comments · Fixed by hyperledger/fabric-gateway#237
Closed

Rename EndpointError to ErrorDetail #2971

andrew-coleman opened this issue Oct 6, 2021 · 0 comments · Fixed by hyperledger/fabric-gateway#237
Assignees

Comments

@andrew-coleman
Copy link
Member

The gateway connects to and invokes external gRPC endpoints and if any of those return an error, they get translated into EndpointError proto messages and sent back to the client in the Details section of the google.rpc.Status error message.
Depending on the SDK language, this will get embedded in the resultant client exception. The current name, ending in 'Error' has unintended connotations when used in Node and Java, since this is not an exception or error in its own right.

This issue is to rename the structure 'ErrorDetail'.
Changes need to be made to (in order):
fabric-protos: /gateway/gateway.proto
fabric: The gateway component that builds and marshals this message
fabric-gateway: The Node SDK that unmarshals this structure, and the samples for the 3 SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant