Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

encode and decode for Attributes #1048

Closed
wants to merge 15 commits into from
Closed

encode and decode for Attributes #1048

wants to merge 15 commits into from

Conversation

AxelNennker
Copy link
Contributor

@AxelNennker AxelNennker commented Aug 7, 2018

Signed-off-by: Axel Nennker axel.nennker@telekom.de

Added methods to encode and decode Attributes for https://jira.hyperledger.org/browse/IS-786

wrote that the encoding is application specific and the ZKPs don't care as long as the result of the encoding is a string representing a number. @swcurran 's counter argument was that it helps interoperabilty if common values are encoded in a common way.

I modelled this along the lines of https://von-agent.readthedocs.io/en/latest/_modules/von_agent/codec.html?highlight=codec but not 100%. Not sure about their float encoding as I think that if
e1 = encode(float1) and e2 = encode(float2) and float1 > float2 then
Number(e1) > Number(e2) etc

Of course all wrappers should use the same encoding or use a Rust implementation which is not 100% correct to put into libindy...

Should this be introduced then all examples should be changed...

Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
@jovfer jovfer added the paused_for_release This PR should be merged after current releasing activity will be done label Aug 9, 2018
@AxelNennker
Copy link
Contributor Author

Working with @sklump one this to have the von_anchor/codec.py and this in sync.

Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
@jovfer jovfer removed the paused_for_release This PR should be merged after current releasing activity will be done label Aug 16, 2018
AxelNennker and others added 6 commits August 17, 2018 22:47
@jovfer
Copy link
Contributor

jovfer commented Mar 1, 2019

related HIPE discussion hyperledger/indy-hipe#47

@jovfer jovfer added the paused label Mar 1, 2019
@jovfer
Copy link
Contributor

jovfer commented Mar 1, 2019

marked as paused as HIPE discussion is in a progress

@esplinr
Copy link
Contributor

esplinr commented Jun 25, 2019

Much of this work is expected to be superseded later in 2019 by the work @brentzundel and @ken-ebert have been doing to standardize proof presentations in the W3C Verifiable Credential specification.

We are nervous about accepting this contribution because the new approach is likely to be backwards incompatible with this one.

Do you have an important need to deploy this capability now? Can you maintain it for your solutions outside of the official SDK?

@AxelNennker
Copy link
Contributor Author

Closing this because it is not really needed to standardize encoding. Would be just nice to have consistent examples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants