Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Events listening cancellation #2940

Closed
pesterev opened this issue Nov 9, 2022 · 1 comment
Closed

[suggestion] Events listening cancellation #2940

pesterev opened this issue Nov 9, 2022 · 1 comment
Assignees
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@pesterev
Copy link
Contributor

pesterev commented Nov 9, 2022

Feature request

I'd like to have the ability to cancel listening for events.

I see the function signature in that way:

pub fn listen_for_events(
        &self,
        event_filter: FilterBox,
        cancellation_token: CancellationToken, // the token that can cancel listening
) -> Result<impl Iterator<Item = Result<Event>>> {

Motivation

Currently, the client library doesn't provide a way to cancel blocking listening for events by a request. There is only the option to kill a blocked thread.

Who can help?

@Erigara @appetrosyan

@pesterev pesterev added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 9, 2022
@pesterev pesterev changed the title [suggestion] Cancellation of listening for events [suggestion] Events listening cancellation Nov 9, 2022
@pesterev
Copy link
Contributor Author

pesterev commented Nov 9, 2022

Originally this issue was inspired by a discussion here

@appetrosyan appetrosyan moved this to Todo in Iroha 2.0 Dec 12, 2022
@SamHSmith SamHSmith assigned SamHSmith and pesterev and unassigned SamHSmith Jan 17, 2023
pesterev added a commit to pesterev/iroha that referenced this issue Feb 6, 2023
pesterev added a commit to pesterev/iroha that referenced this issue Feb 6, 2023
… a transaction

Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev added a commit to pesterev/iroha that referenced this issue Feb 6, 2023
… a transaction

Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
@github-project-automation github-project-automation bot moved this from Todo to Done in Iroha 2.0 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants