ENS metadata and reverse ENS record set #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
reviewed
Nov 28, 2024
| * <p>Generated with web3j version 4.12.2. | ||
| */ | ||
| @SuppressWarnings("rawtypes") | ||
| public class ReverseRegistrar extends Contract { |
There was a problem hiding this comment.
is there any possibility to generate this wrapper when we need it, as we are doing for the integration tests in order to avoid this hardcode here
There was a problem hiding this comment.
I dont it think it will be possible, the same logic is done for ENS, ENS registry and ENS offchain resolver contracts. As these classes need to be present in compile time and included in the JAR.
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds retrieving ENS metadata and lets user set reverse ENS record
Where should the reviewer start?
all
Why is it needed?
Functionality was not available
Checklist