Skip to content

Commit e68bd3e

Browse files
committed
additional changes and addressing feedback
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
1 parent 23a01a8 commit e68bd3e

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,6 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
5959
&& rustup target add x86_64-unknown-linux-gnu \
6060
&& rustup target add x86_64-unknown-none \
6161
&& rustup target add x86_64-pc-windows-msvc \
62+
&& rustup toolchain add nightly-x86_64-unknown-linux-gnu \
6263
&& cargo install just
6364

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ All contributions come through pull requests. To submit a proposed change, we re
3838
#### Use work-in-progress PRs for early feedback
3939

4040
A good way to communicate before investing too much time is to create a "Work-in-progress" PR and share it with your reviewers. The standard way of doing this is to add a "[WIP]" prefix in your PR's title and open the pull request as a draft.
41+
4142
### Developer Certificate of Origin: Signing your work
4243

4344
#### Every commit needs to be signed
@@ -82,3 +83,7 @@ git push --force-with-lease <remote-name> <branch-name>
8283
```
8384

8485
*Credit: This doc was cribbed from Dapr.*
86+
87+
### Rust Analyzer
88+
89+
If you are using the [Rust Analyzer](https://rust-analyzer.github.io/manual.html) then you may need to set the configuration option `rust-analyzer.rustfmt.extraArgs` to `["+nightly"]` to ensure that formatting works correctly as this project has a [`rustfmt.toml`](./rustfmt.toml) file that uses nightly features.

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,6 @@ If you get the error `Error: NoHypervisorFound` and KVM or mshv is set up then t
224224

225225
For more details on how to verify that KVM is correctly installed and permissions are correct, follow the guide [here](https://help.ubuntu.com/community/KVM/Installation).
226226

227-
### Rust Analyzer
228-
229-
If you are using the [Rust Analyzer](https://rust-analyzer.github.io/manual.html) then you may need to set the configuration option `rust-analyzer.rustfmt.extraArgs` to `["+nightly"]` to ensure that formatting works correctly as this project has a [`rustfmt.toml`](./rustfmt.toml) file that uses nightly features.
230-
231227
### Or you can use a codespace
232228

233229
[![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/hyperlight-dev/hyperlight)

src/hyperlight_host/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ tracing-opentelemetry = "0.27.0"
9494
opentelemetry = "0.26.0"
9595
opentelemetry-otlp = { version = "0.26.0", features = ["default"] }
9696
opentelemetry_sdk = { version = "0.26.0", features = ["rt-tokio"] }
97-
opentelemetry-semantic-conventions = "0.26.0"
9897
tokio = { version = "1.34.0", features = ["full"] }
9998
criterion = "0.5.1"
10099
tracing-chrome = "0.7.2"

0 commit comments

Comments
 (0)