Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding @types #31

Closed
pavelcerveny opened this issue Jul 16, 2018 · 6 comments · Fixed by #32
Closed

Adding @types #31

pavelcerveny opened this issue Jul 16, 2018 · 6 comments · Fixed by #32

Comments

@pavelcerveny
Copy link

Hi, could you add types into the package itself or create them in @types/alcaeus ? Thanks
@tpluscode tpluscode mentioned this issue Jul 18, 2018
Merged
@tpluscode
Copy link
Member

Hi @pavelcerveny. Please try 0.4.1

@pavelcerveny
Copy link
Author

Hi, thanks for quick response. Unfortunately, in your code there're hardcoded some paths, please see this error:

node_modules/alcaeus/dist/src/Resources/HydraResource.d.ts(14,25): error TS2307: Cannot find
module '../../../../../../../../Users/tomaszpluskiewicz/projects/github/wikibus/heracles/src/TypeCollection'.

@tpluscode
Copy link
Member

Weird, how did that happen. I regenerated the typing using tsc switch. Any ideas what could have gone wrong?

@tpluscode tpluscode reopened this Jul 20, 2018
@tpluscode
Copy link
Member

Ah apparently it was caused by microsoft/TypeScript#25511 in typescript ~2.9. Please try again with 0.4.2

@pavelcerveny
Copy link
Author

Yes, it's working now. Good job in finding the problem.

@tpluscode
Copy link
Member

Fantastic. You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typings hypermedia-app/Alcaeus
2 participants
@tpluscode @pavelcerveny