Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On iPhone X, camera flash and reverse camera icons in the upper corners are bordering the edge/cut off #375

Closed
ulukaya opened this issue Jan 24, 2018 · 4 comments
Assignees

Comments

@ulukaya
Copy link
Contributor

ulukaya commented Jan 24, 2018

y4dfqhtzxcc

@Peach82
Copy link

Peach82 commented Jan 29, 2018

Had the same problem. To solve it in the ConstraintsSetup.swift file I changed line 120 from

for attribute in topViewAttributes {
     view.addConstraint(NSLayoutConstraint(item: topView, attribute: attribute,
        relatedBy: .equal, toItem: self.view, attribute: attribute,
        multiplier: 1, constant: 0))
    }

to

for attribute in topViewAttributes {
        if #available(iOS 11.0, *) {
            view.addConstraint(NSLayoutConstraint(item: topView, attribute: attribute,
                                                  relatedBy: .equal, toItem: self.view.safeAreaLayoutGuide, attribute: attribute,
                                                  multiplier: 1, constant: 0))
        } else {
            view.addConstraint(NSLayoutConstraint(item: topView, attribute: attribute,
                                                  relatedBy: .equal, toItem: self.view, attribute: attribute,
                                                  multiplier: 1, constant: 0))
        }
    }

@ulukaya
Copy link
Contributor Author

ulukaya commented Feb 5, 2018

Seems like this PR is targeting it. #372

@arvidurs
Copy link

arvidurs commented Feb 7, 2018

The same with the bottom controls, they could be pushed up on the iPhoneX

@annjawn
Copy link

annjawn commented Mar 28, 2018

@onmyway133 PR #372 needs to be merged please.

@ulukaya ulukaya closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants