Add zenodo link to docs #36
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 67 67
Lines 7276 7276
Branches 1179 1179
=======================================
Hits 6408 6408
Misses 591 591
Partials 277 277 ☔ View full report in Codecov by Sentry. |
| @@ -91,6 +91,8 @@ please use the DOI of the specific version that you have employed. You can | |||
| find it by clicking on the DOI badge below. | |||
|
|
|||
| .. image:: https://zenodo.org/badge/doi/10.5281/zenodo.10252344.svg | |||
| :class: sd-bg-transparent | |||
There was a problem hiding this comment.
I can't see any difference between this one and the one in doc/citing.rst, which doesn't have it. Could it be browser dependent?
According to https://sphinx-design.readthedocs.io/en/latest/css_classes.html#colors, this is suppose to change the background to transparent right? If so, could the effect be visible on the edges?
There was a problem hiding this comment.
Yes, without this there is a gray edge in dark mode. See also hyperspy/holospy#27 (comment)
doc/citing.rst
Outdated
| @@ -12,4 +12,5 @@ version. If you are citing HoloSpy because you have used it to process data, | |||
| please use the DOI of the specific version that you have employed. You can | |||
| find it by clicking on the DOI badge below: | |||
|
|
|||
| To be updated after first release. | |||
| .. image:: https://zenodo.org/badge/doi/10.5281/zenodo.10252344.svg | |||
There was a problem hiding this comment.
Similarly as in hyperspy/holospy#27, maybe this page can be removed since this is already in in the intro.rst page?
There was a problem hiding this comment.
Indeed, it is actually not displayed anywhere and must have been forgotten in a previous PR when the information was placed in intro.rst.
Edit: It was linked in the menu, but redundant. So I removed it also from the menu.
jlaehne
force-pushed
the
jlaehne-patch-1
branch
from
df3d794 to
2f2c46d
Compare
|
failing tests are a version conflict of |
Progress of the PR