Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveRecord::Base#new? should be #new_record? #120

Closed
catmando opened this issue Jan 29, 2019 · 3 comments
Closed

ActiveRecord::Base#new? should be #new_record? #120

catmando opened this issue Jan 29, 2019 · 3 comments
Labels
bug Something isn't working enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone
alpha1.5

Comments

@catmando
Copy link
Contributor

catmando commented Jan 29, 2019 •
edited
Loading

deprecate new? and replace with new_record? which is the ActiveRecord method name.

Note: historically I think the name new? came in from perhaps Volt, as MongoMapper uses new?
@catmando catmando added the bug Something isn't working label Jan 29, 2019
@catmando catmando added the enhancement New feature or request label Jan 29, 2019
@catmando catmando added this to the alpha1.4 milestone Feb 15, 2019
@catmando
Copy link
Contributor Author

needed to use new? for #117 so this got done with that.

@catmando
Copy link
Contributor Author

I don't see any reason to deprecate. Its just an alias method

@Tim-Blokdijk
Copy link
Contributor

Seems to work, issue can be closed.
Does not need explicit documentation, as it's a ActiveRecord method.

@catmando catmando modified the milestones: alpha1.4, alpha1.5 Apr 18, 2019
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Milestone
alpha1.5
Development

No branches or pull requests
2 participants
@catmando @Tim-Blokdijk