Skip to content

Commit 07c544b

Browse files
fix: addressing review comments
1 parent 8d31364 commit 07c544b

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

projects/observability/src/shared/components/topology/d3/interactions/topology-interaction-control.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export class TopologyInteractionControlComponent implements OnInit {
112112
}
113113

114114
public ngOnInit(): void {
115-
if (this.interactionControlData.topologyConfig.autoZoomToFit) {
115+
if (this.interactionControlData.topologyConfig.shouldAutoZoomToFit) {
116116
this.zoomToFit();
117117
}
118118
}

projects/observability/src/shared/components/topology/topology.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class TopologyComponent implements OnChanges, OnDestroy {
4747
public showBrush?: boolean = true;
4848

4949
@Input()
50-
public autoZoomToFit?: boolean = false;
50+
public shouldAutoZoomToFit?: boolean = false;
5151

5252
@ViewChild('topologyContainer', { static: true })
5353
private readonly container!: ElementRef;
@@ -73,7 +73,7 @@ export class TopologyComponent implements OnChanges, OnDestroy {
7373
edgeDataSpecifiers: this.edgeDataSpecifiers,
7474
tooltipRenderer: this.tooltipRenderer,
7575
showBrush: this.showBrush,
76-
autoZoomToFit: this.autoZoomToFit
76+
shouldAutoZoomToFit: this.shouldAutoZoomToFit
7777
});
7878

7979
// Angular doesn't like introducing new child views mid-change detection

projects/observability/src/shared/components/topology/topology.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export interface TopologyConfiguration {
5252
/**
5353
* If true, it will be automatic zoom to fit
5454
*/
55-
autoZoomToFit?: boolean;
55+
shouldAutoZoomToFit?: boolean;
5656

5757
/**
5858
* A list of specifiers for node data. Up to one will be selectable to the user,

projects/observability/src/shared/dashboard/widgets/topology/topology-widget-renderer.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ import { TopologyWidgetModel } from './topology-widget.model';
6060
[nodeDataSpecifiers]="data.nodeSpecs"
6161
[edgeDataSpecifiers]="data.edgeSpecs"
6262
[showBrush]="this.model.showBrush"
63-
[autoZoomToFit]="this.model.autoZoomToFit"
63+
[shouldAutoZoomToFit]="this.model.shouldAutoZoomToFit"
6464
>
6565
</ht-topology>
6666
</div>

projects/observability/src/shared/dashboard/widgets/topology/topology-widget.model.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ export class TopologyWidgetModel {
3333
public showBrush?: boolean = true;
3434

3535
@ModelProperty({
36-
key: 'autoZoomToFit',
37-
displayName: 'Auto Zoom To Fit',
36+
key: 'shouldAutoZoomToFit',
37+
displayName: 'Should Auto Zoom To Fit',
3838
type: BOOLEAN_PROPERTY.type,
3939
required: false
4040
})
41-
public autoZoomToFit?: boolean = false;
41+
public shouldAutoZoomToFit?: boolean = false;
4242

4343
@ModelInject(MODEL_API)
4444
private readonly api!: ModelApi;

0 commit comments

Comments
 (0)