Skip to content

Commit 243339d

Browse files
authored
refactor: adding string array filter and minor table fix (#1479)
1 parent 5545b9d commit 243339d

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

projects/components/src/filtering/filter/builder/filter-builder-lookup.service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { FilterAttributeType } from '../filter-attribute-type';
55
import { AbstractFilterBuilder } from './types/abstract-filter-builder';
66
import { BooleanFilterBuilder } from './types/boolean-filter-builder';
77
import { NumberFilterBuilder } from './types/number-filter-builder';
8+
import { StringArrayFilterBuilder } from './types/string-array-filter-builder';
89
import { StringFilterBuilder } from './types/string-filter-builder';
910
import { StringMapFilterBuilder } from './types/string-map-filter-builder';
1011

@@ -22,7 +23,8 @@ export class FilterBuilderLookupService {
2223
return new StringFilterBuilder();
2324
case FilterAttributeType.StringMap:
2425
return new StringMapFilterBuilder();
25-
case FilterAttributeType.StringArray: // Unsupported
26+
case FilterAttributeType.StringArray:
27+
return new StringArrayFilterBuilder();
2628
case FilterAttributeType.Timestamp: // Unsupported
2729
throw new Error(`Filter builder not found for attribute of type '${type}'.`);
2830
default:
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { FilterAttributeType } from '../../filter-attribute-type';
2+
import { FilterOperator } from '../../filter-operators';
3+
import { AbstractFilterBuilder } from './abstract-filter-builder';
4+
5+
export class StringArrayFilterBuilder extends AbstractFilterBuilder<string> {
6+
public supportedAttributeType(): FilterAttributeType {
7+
return FilterAttributeType.StringArray;
8+
}
9+
10+
public supportedTopLevelOperators(): FilterOperator[] {
11+
return [FilterOperator.In];
12+
}
13+
14+
public supportedSubpathOperators(): FilterOperator[] {
15+
return [];
16+
}
17+
18+
protected buildValueString(value: string | string[]): string {
19+
return String(value);
20+
}
21+
}

projects/components/src/table/header/table-header-cell-renderer.component.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
align-items: center;
77
width: 100%;
88
height: 32px;
9-
9+
padding: 0 6px;
1010
&.sortable {
1111
cursor: pointer;
1212
}
@@ -57,7 +57,7 @@
5757
}
5858

5959
.state-checkbox {
60-
margin-left: 12px;
60+
margin-left: 6px;
6161
}
6262
}
6363

0 commit comments

Comments
 (0)