refactor: updating tests

Author: anandtiwary

projects/components/src/table/table.component.test.ts

@@ -60,7 +60,7 @@ describe('Table component', () => {
         queryParamMap: EMPTY
       }),
       mockProvider(DomElementMeasurerService, {
-        measureHtmlElement: (): ClientRect => ({
+        measureHtmlElement: (): Partial<ClientRect> => ({
           top: 0,
           left: 0,
           bottom: 20,
@@ -397,37 +397,6 @@ describe('Table component', () => {
     });
   }));
 
-  test('should trigger toggle row selection for multi row select config', () => {
-    const columns = buildColumns();
-    const spectator = createHost(
-      `<ht-table [columnConfigs]="columnConfigs" [data]="data" [selectionMode]="selectionMode"
-         [mode]="mode" (selectionsChange)="selectionsChange($event)"></ht-table>`,
-      {
-        hostProps: {
-          columnConfigs: columns,
-          data: buildData(),
-          selectionMode: TableSelectionMode.Multiple,
-          mode: TableMode.Flat
-        }
-      }
-    );
-
-    const row: StatefulTableRow = {
-      $$state: {
-        parent: undefined,
-        expanded: false,
-        selected: false,
-        root: false,
-        leaf: true,
-        depth: 1
-      }
-    };
-
-    const spyToggleRowSelection = spyOn(spectator.component, 'toggleRowSelected');
-    spectator.component.onDataCellClick(row);
-    expect(spyToggleRowSelection).toHaveBeenCalledWith(row);
-  });
-
   test('should emit selections on toggle select', () => {
     const mockSelectionsChange = jest.fn();
     const columns = buildColumns();

projects/observability/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts

@@ -1,12 +1,4 @@
-import {
-  ChangeDetectionStrategy,
-  ChangeDetectorRef,
-  Component,
-  Inject,
-  OnInit,
-  TemplateRef,
-  ViewChild
-} from '@angular/core';
+import { ChangeDetectionStrategy, ChangeDetectorRef, Component, Inject, OnInit } from '@angular/core';
 import {
   assertUnreachable,
   Dictionary,
@@ -70,7 +62,7 @@ import { TableWidgetModel } from './table-widget.model';
           [selectControls]="this.selectControls$ | async"
           [checkboxControls]="this.checkboxControls$ | async"
           [selectedRows]="this.selectedRows"
-          [customControlContent]="this.isCustomControlPresent() ? customControlDetail : undefined"
+          [customControlContent]="(this.isCustomControlPresent | htMemoize) ? customControlDetail : undefined"
           [viewItems]="this.viewItems"
           (searchChange)="this.onSearchChange($event)"
           (selectChange)="this.onSelectChange($event)"
@@ -124,9 +116,6 @@ export class TableWidgetRendererComponent
 
   public selectedRows?: StatefulTableRow[] = [];
 
-  @ViewChild('customControlDetail')
-  public readonly customControlDetailTemplate!: TemplateRef<unknown>;
-
   private readonly toggleFilterSubject: Subject<TableFilter[]> = new BehaviorSubject<TableFilter[]>([]);
   private readonly searchFilterSubject: Subject<TableFilter[]> = new BehaviorSubject<TableFilter[]>([]);
   private readonly selectFilterSubject: BehaviorSubject<TableFilter[]> = new BehaviorSubject<TableFilter[]>([]);
@@ -397,22 +386,24 @@ export class TableWidgetRendererComponent
 
   public onRowSelection(selections: StatefulTableRow[]): void {
     this.selectedRows = selections;
-    // Todo: Revisit this
+    /**
+     * Todo: Stich this with selection handlers
+     */
   }
 
   private getRowClickInteractionHandler(selectedRow: StatefulTableRow): InteractionHandler | undefined {
     return this.getInteractionHandler(selectedRow, this.api.model.getRowClickHandlers());
   }
 
   private getInteractionHandler(
-    selectedRow: StatefulTableRow,
-    rowInteractionHandlers: TableWidgetRowInteractionModel[] = []
+    row: StatefulTableRow,
+    rowHandlers: TableWidgetRowInteractionModel[] = []
   ): InteractionHandler | undefined {
-    const matchedSelectionHandlers = rowInteractionHandlers
-      .filter(selectionModel => selectionModel.appliesToCurrentRowDepth(selectedRow.$$state.depth))
+    const matchedHandlers = rowHandlers
+      .filter(interactionModel => interactionModel.appliesToCurrentRowDepth(row.$$state.depth))
       .sort((model1, model2) => model2.rowDepth - model1.rowDepth);
 
-    return !isEmpty(matchedSelectionHandlers) ? matchedSelectionHandlers[0].handler : undefined;
+    return !isEmpty(matchedHandlers) ? matchedHandlers[0].handler : undefined;
   }
 
   private pickPersistColumnProperties(column: TableColumnConfig): Pick<TableColumnConfig, 'id' | 'visible'> {