refactor: adding tests

Author: anandtiwary

projects/observability/src/shared/dashboard/data/graphql/topology/topology-data-source.model.test.ts

@@ -1,4 +1,4 @@
-import { isEqualIgnoreFunctions } from '@hypertrace/common';
+import { Color, isEqualIgnoreFunctions } from '@hypertrace/common';
 import { GraphQlTimeRange, MetricAggregationType } from '@hypertrace/distributed-tracing';
 import { GraphQlRequestCacheability, GraphQlRequestOptions } from '@hypertrace/graphql-client';
 import { ModelApi } from '@hypertrace/hyperdash';
@@ -8,6 +8,10 @@ import {
   ENTITY_TOPOLOGY_GQL_REQUEST,
   TopologyNodeSpecification
 } from '../../../../graphql/request/handlers/entities/query/topology/entity-topology-graphql-query-handler.service';
+import { MetricAggregationSpecificationModel } from '../specifiers/metric-aggregation-specification.model';
+import { TopologyMetricCategoryModel } from './metrics/topology-metric-category.model';
+import { TopologyMetricWithCategoryModel } from './metrics/topology-metric-with-category.model';
+import { TopologyMetricsModel } from './metrics/topology-metrics.model';
 import { TopologyDataSourceModel } from './topology-data-source.model';
 
 describe('topology data source model', () => {
@@ -17,6 +21,57 @@ describe('topology data source model', () => {
   let lastEmittedQuery: unknown;
   let lastEmittedQueryRequestOption: GraphQlRequestOptions | undefined;
 
+  const createCategoryModel = (
+    name: string,
+    minValue: number,
+    fillColor: Color,
+    strokeColor: Color,
+    focusColor: Color,
+    maxValue?: number
+  ): TopologyMetricCategoryModel => {
+    const categoryModel = new TopologyMetricCategoryModel();
+    categoryModel.name = name;
+    categoryModel.minValue = minValue;
+    categoryModel.maxValue = maxValue;
+    categoryModel.fillColor = fillColor;
+    categoryModel.strokeColor = strokeColor;
+    categoryModel.focusColor = focusColor;
+
+    return categoryModel;
+  };
+
+  const createSpecificationModel = (metric: string, aggregation: MetricAggregationType) => {
+    const specification = new MetricAggregationSpecificationModel();
+    specification.metric = metric;
+    specification.aggregation = aggregation;
+
+    specification.modelOnInit();
+
+    return specification;
+  };
+
+  const createMetricWithCategory = (
+    spec: MetricAggregationSpecificationModel,
+    categories: TopologyMetricCategoryModel[]
+  ) => {
+    const withCategoryModel = new TopologyMetricWithCategoryModel();
+    withCategoryModel.specification = spec;
+    withCategoryModel.categories = categories;
+
+    return withCategoryModel;
+  };
+
+  const createTopologyMetricsModel = (metric: string, aggregation: MetricAggregationType) => {
+    const primary = createMetricWithCategory(createSpecificationModel(metric, aggregation), [
+      createCategoryModel(metric, 0, Color.Blue2, Color.Blue3, Color.Blue4, 10)
+    ]);
+
+    const metricsModel: TopologyMetricsModel = new TopologyMetricsModel();
+    metricsModel.primary = primary;
+
+    return metricsModel;
+  };
+
   beforeEach(() => {
     const mockApi: Partial<ModelApi> = {
       getTimeRange: jest.fn(() => testTimeRange)
@@ -25,12 +80,9 @@ describe('topology data source model', () => {
     model.downstreamEntityTypes = [ObservabilityEntityType.Api, ObservabilityEntityType.Backend];
     model.upstreamEntityTypes = [ObservabilityEntityType.Service];
     model.entityType = ObservabilityEntityType.Service;
-    model.nodeMetricSpecifications = [
-      specBuilder.metricAggregationSpecForKey('numCalls', MetricAggregationType.Average)
-    ];
-    model.edgeMetricSpecifications = [
-      specBuilder.metricAggregationSpecForKey('duration', MetricAggregationType.Average)
-    ];
+    model.nodeMetricsModel = createTopologyMetricsModel('numCalls', MetricAggregationType.Average);
+    model.edgeMetricsModel = createTopologyMetricsModel('duration', MetricAggregationType.Average);
+
     model.api = mockApi as ModelApi;
     model.query$.subscribe(query => {
       lastEmittedQuery = query.buildRequest([]);

projects/observability/src/shared/dashboard/widgets/topology/edge/curved/entity-edge-curve-renderer.service.ts

@@ -263,11 +263,13 @@ export class EntityEdgeCurveRendererService implements TopologyEdgeRenderDelegat
     primaryMetricCategory?: TopologyMetricCategoryData,
     secondaryMetricCategory?: TopologyMetricCategoryData
   ): string {
-    if (secondaryMetricCategory?.highestPrecedence === true || !primaryMetricCategory) {
-      return this.formattedMetricValue(secondaryMetricAggregation!.value, secondaryMetricAggregation?.units);
+    if (secondaryMetricAggregation && (secondaryMetricCategory?.highestPrecedence === true || !primaryMetricCategory)) {
+      return this.formattedMetricValue(secondaryMetricAggregation.value, secondaryMetricAggregation?.units);
     }
 
-    return this.formattedMetricValue(primaryMetricAggregation!.value, primaryMetricAggregation?.units);
+    return primaryMetricAggregation
+      ? this.formattedMetricValue(primaryMetricAggregation.value, primaryMetricAggregation?.units)
+      : '-';
   }
 
   private formattedMetricValue(valueToShow: number, unit?: string): string {