Skip to content

Commit 5aa9a4f

Browse files
authored
fix: explorer table expanding beyond page bounds (#485)
* fix: explorer table expanding beyond page bounds * fix: change oveflow to hidden for clarity * fix: safari squishing
1 parent 6c83f78 commit 5aa9a4f

File tree

6 files changed

+37
-20
lines changed

6 files changed

+37
-20
lines changed

projects/components/src/paginator/paginator.component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
align-items: center;
99

1010
height: $paginator-height;
11-
padding-top: 6px;
11+
padding: 6px 0;
1212
border-top: 1px solid $color-border;
1313

1414
.label {

projects/components/src/panel/panel.component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
border-radius: 2px;
1111

1212
&.expanded {
13-
margin-bottom: 8px;
13+
padding-bottom: 8px;
1414
}
1515

1616
.header-content {

projects/components/src/table/table.component.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
@import 'layout';
33

44
.table {
5-
display: flex;
6-
flex-direction: column;
75
height: 100%;
8-
width: 100%;
9-
position: relative;
106
}
117

128
.title-row {

projects/distributed-tracing/src/shared/dashboard/widgets/table/table-widget-renderer.component.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
}
66

77
.table {
8-
flex: 1 1;
9-
width: 100%;
8+
flex: 1;
9+
min-height: 0;
1010
}
1111

1212
.header-margin {
Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,40 @@
11
@import 'font';
22

3-
.explorer-container {
3+
.explorer {
44
display: flex;
55
flex-direction: column;
6-
padding: 24px 24px 0;
7-
height: calc(100% - 40px);
6+
overflow: hidden;
7+
height: 100%;
88

9-
.filter-bar {
10-
margin-top: 16px;
9+
.explorer-header {
10+
flex: 0;
11+
}
12+
13+
.explorer-content {
14+
display: flex;
15+
flex-direction: column;
16+
padding: 24px 24px 0;
17+
flex: 1;
18+
min-height: 0;
19+
}
20+
21+
.explorer-data-toggle {
22+
flex: 0;
23+
padding-bottom: 16px;
24+
}
25+
26+
.explorer-filter-bar {
27+
flex: 0;
28+
padding-bottom: 8px;
1129
}
1230

1331
.panel-title {
1432
color: black;
1533
}
1634

1735
.visualization-panel {
18-
padding-top: 8px;
36+
flex: 0;
37+
1938
.label {
2039
@include body-1-medium;
2140
}
@@ -29,14 +48,15 @@
2948
}
3049

3150
.results-panel {
51+
flex: 1;
3252
overflow: hidden;
33-
flex: 1 1 auto;
53+
3454
.label {
3555
@include body-1-medium;
3656
}
3757

3858
.results-panel-content {
39-
margin-top: 12px;
59+
padding-top: 12px;
4060
}
4161
}
4262
}

projects/observability/src/pages/explorer/explorer.component.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,18 @@ import {
1919
styleUrls: ['./explorer.component.scss'],
2020
changeDetection: ChangeDetectionStrategy.OnPush,
2121
template: `
22-
<div class="vertical-flex-layout">
23-
<ht-page-header></ht-page-header>
24-
<div class="fill-container explorer-container">
22+
<div class="explorer">
23+
<ht-page-header class="explorer-header"></ht-page-header>
24+
<div class="explorer-content">
2525
<ht-toggle-group
26+
class="explorer-data-toggle"
2627
[items]="this.contextItems"
2728
[activeItem]="this.activeContextItem$ | async"
2829
(activeItemChange)="this.onContextUpdated($event.value)"
2930
></ht-toggle-group>
3031
3132
<ht-filter-bar
32-
class="filter-bar"
33+
class="explorer-filter-bar"
3334
[attributes]="this.attributes$ | async"
3435
[syncWithUrl]="true"
3536
(filtersChange)="this.onFiltersUpdated($event)"

0 commit comments

Comments
 (0)