Skip to content

Commit 72670f3

Browse files
refactor: always use query limits (#1496)
* refactor: always use query limits * test: update test limits
1 parent 5da419c commit 72670f3

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

projects/observability/src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('API Trace detail data source model', () => {
7979
expect.objectContaining({
8080
requestType: TRACE_GQL_REQUEST,
8181
traceId: 'test',
82-
spanLimit: 0,
82+
spanLimit: 1000,
8383
timestamp: undefined,
8484
traceProperties: expect.arrayContaining([
8585
expect.objectContaining({ name: 'tags' }),
@@ -99,7 +99,7 @@ describe('API Trace detail data source model', () => {
9999
expect.objectContaining({
100100
requestType: TRACE_GQL_REQUEST,
101101
traceId: 'test',
102-
spanLimit: 0,
102+
spanLimit: 1000,
103103
timestamp: undefined,
104104
traceProperties: expect.arrayContaining([
105105
expect.objectContaining({ name: 'tags' }),
@@ -119,7 +119,7 @@ describe('API Trace detail data source model', () => {
119119
expect.objectContaining({
120120
requestType: TRACE_GQL_REQUEST,
121121
traceId: 'test',
122-
spanLimit: 0,
122+
spanLimit: 1000,
123123
timestamp: new Date(1568907645141),
124124
traceProperties: expect.arrayContaining([
125125
expect.objectContaining({ name: 'tags' }),

projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('API Trace detail data source model', () => {
7474
expect.objectContaining({
7575
requestType: TRACE_GQL_REQUEST,
7676
traceId: 'test',
77-
spanLimit: 0,
77+
spanLimit: 1000,
7878
timestamp: undefined,
7979
traceProperties: expect.arrayContaining([
8080
expect.objectContaining({ name: 'tags' }),
@@ -94,7 +94,7 @@ describe('API Trace detail data source model', () => {
9494
expect.objectContaining({
9595
requestType: TRACE_GQL_REQUEST,
9696
traceId: 'test',
97-
spanLimit: 0,
97+
spanLimit: 1000,
9898
timestamp: new Date(1576364117792),
9999
traceProperties: expect.arrayContaining([
100100
expect.objectContaining({ name: 'tags' }),

projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class TraceDetailDataSourceModel extends GraphQlDataSourceModel<TraceDeta
4242
requestType: TRACE_GQL_REQUEST,
4343
traceType: this.trace[traceTypeKey],
4444
traceId: this.trace[traceIdKey],
45-
spanLimit: 0,
45+
spanLimit: 1000,
4646
timestamp: this.dateCoercer.coerce(this.startTime ?? this.trace.startTime),
4747
traceProperties: this.getTraceAttributes().map(attribute =>
4848
this.attributeSpecBuilder.attributeSpecificationForKey(attribute)

0 commit comments

Comments
 (0)