Skip to content

Commit 9ccc33d

Browse files
authored
fix: bad terrible awful totally unacceptable way of returning from method (#829)
1 parent f4b3436 commit 9ccc33d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

projects/distributed-tracing/src/shared/dashboard/widgets/table/table-widget-renderer.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,14 @@ export class TableWidgetRendererComponent
273273

274274
public onSelectChange(changed: TableSelectChange): void {
275275
if (changed.values.length === 0) {
276-
// tslint:disable-next-line: no-void-expression
277-
return this.selectFilterSubject.next(this.removeFilters(changed.select.options[0].metaValue.field));
276+
this.selectFilterSubject.next(this.removeFilters(changed.select.options[0].metaValue.field));
277+
278+
return;
278279
}
279280

280281
const tableFilters: TableFilter[] = changed.values.map((option: TableFilterControlOption) => option.metaValue);
281282

282-
// tslint:disable-next-line: no-void-expression
283-
return this.selectFilterSubject.next(this.mergeFilters(toInFilter(tableFilters)));
283+
this.selectFilterSubject.next(this.mergeFilters(toInFilter(tableFilters)));
284284
}
285285

286286
public onCheckboxChange(changed: TableCheckboxChange): void {

0 commit comments

Comments
 (0)