Skip to content

fix: improve query error console messaging #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix: improve query error console messaging #1435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901ffef
fix: improve query error console messaging
jake-bassett Feb 15, 2022
f13b62c
fix: add mutation message as well
jake-bassett Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions projects/graphql-client/src/graphql-request.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Inject, Injectable } from '@angular/core';
import { Apollo, gql } from 'apollo-angular';
import { includes, uniq } from 'lodash-es';
import { includes, isNil, uniq } from 'lodash-es';
import { defer, EMPTY, Observable, Observer, of, Subject, zip } from 'rxjs';
import { buffer, catchError, debounceTime, filter, map, mergeMap, take } from 'rxjs/operators';
import { buffer, catchError, debounceTime, filter, map, mergeMap, take, tap } from 'rxjs/operators';
import {
GraphQlHandler,
GraphQlHandlerType,
Expand Down Expand Up @@ -151,15 +151,31 @@ export class GraphQlRequestService {
errorPolicy: 'all',
fetchPolicy: options.cacheability
})
.pipe(map(response => response.data));
.pipe(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should do the same in executeMutation below

tap(response => {
if (!isNil(response.errors)) {
// tslint:disable-next-line: no-console
console.error(`Query response error(s) for request '${requestString}'`, response.errors);
}
}),
map(response => response.data)
);
}

private executeMutation<TResponse extends { [key: string]: unknown }>(requestString: string): Observable<TResponse> {
return this.apollo
.mutate<TResponse>({
mutation: gql(`mutation ${requestString}`)
})
.pipe(mergeMap(response => (response.data ? of(response.data) : EMPTY)));
.pipe(
tap(response => {
if (!isNil(response.errors)) {
// tslint:disable-next-line: no-console
console.error(`Mutation response error(s) for request '${requestString}'`, response.errors);
}
}),
mergeMap(response => (response.data ? of(response.data) : EMPTY))
);
}

private getResultForRequest<T>(request: GraphQlRequest): Observable<T> {
Expand Down