ENG-48179: Revert NewClient api usage in configgrpc.

puneet-traceable · puneet-traceable · commit 736504c6bc9d · 2024-09-17T19:50:13.000+05:30
With NewClient API usage, we are facing issues at few customers who have intermediate proxies between collector and platform. With NewClient API instead DialContext, DNS resolution happens on the client side while it should happen on proxy. Also, with SGProxy client does not get the correct certificate. can be changed once grpc fixes grpc/grpc-go#7556 and otel collector picks the fix
diff --git a/config/configgrpc/configgrpc.go b/config/configgrpc/configgrpc.go
@@ -224,7 +224,7 @@ func (gcs *ClientConfig) ToClientConn(ctx context.Context, host component.Host,
 		return nil, err
 	}
 	opts = append(opts, extraOpts...)
-	return grpc.NewClient(gcs.sanitizedEndpoint(), opts...)
+	return grpc.DialContext(ctx, gcs.sanitizedEndpoint(), opts...)
 }
 
 func (gcs *ClientConfig) toDialOptions(ctx context.Context, host component.Host, settings component.TelemetrySettings) ([]grpc.DialOption, error) {

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ func (gcs *ClientConfig) ToClientConn(ctx context.Context, host component.Host,`
`224`	`224`	`return nil, err`
`225`	`225`	`}`
`226`	`226`	`opts = append(opts, extraOpts...)`
`227`		`- return grpc.NewClient(gcs.sanitizedEndpoint(), opts...)`
	`227`	`+ return grpc.DialContext(ctx, gcs.sanitizedEndpoint(), opts...)`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`func (gcs *ClientConfig) toDialOptions(ctx context.Context, host component.Host, settings component.TelemetrySettings) ([]grpc.DialOption, error) {`